search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Are "[time]" and seed from the same data source? #21

Closed BoosterCore closed 1 year ago

BoosterCore commented 1 year ago

I tried to use "Random Number" to drive the seed of "KSampler(WAS)", and I add it to Image naming use "Number to Text", I used "Save Text File" with "[time]" to save prompt. But ... every queue, Random Number give me "0". 微信图片_20230402153721 微信图片_20230402153725 微信图片_20230402153730 微信图片_20230402153735 微信图片_20230402153739

BoosterCore commented 1 year ago

"Random Number" will only give me a number from minimum to maximum?If so, then a node that converts the seed to text may be needed.

BoosterCore commented 1 year ago

I set the maximum,it give other numbers between mini and max now. It seems to prove my idea, random number and seed are not directly equivalent.

BoosterCore commented 1 year ago

So looking forward to the solution you mentioned at the end of the discussion below, hopefully "[time]" will work in Image Save. By the way, are "[time]" and Seed really equivalent?

15

WASasquatch commented 1 year ago

Time is microtime, that can be converted into dates and such. Same thing images are saved with in WebUI if you don't save with prompt. Seed is a random int with a extremely high ceiling (too high honestly, can cause errors in programs).

WASasquatch commented 1 year ago

So the tokens can now be used in Save Text File and Save Image node, additionally, you can add your own tokens as well.

https://github.com/WASasquatch/was-node-suite-comfyui#text-tokens

image image

BoosterCore commented 1 year ago

Thank you very much for your detailed answer and these great improvements！

WASasquatch commented 1 year ago

Thank you very much for your detailed answer and these great improvements！

Thank you! Just added ability to import a1111 styles file just now. Bed time for me.

BoosterCore commented 1 year ago

Thank you very much for your detailed answer and these great improvements！

Thank you! Just added ability to import a1111 styles file just now. Bed time for me.

I have tried it, I have modifyed the styles.csv location in json, but I got errors and red nodes. 微信图片_20230404232036 微信图片_20230404232040

BoosterCore commented 1 year ago

Here is my styles.csv styles.csv

WASasquatch commented 1 year ago

Oh your file isn't messed up like mine is. Both mine from older WebUI, and new version has weird encoding like it's utf-16 (but it isn't) so I had to add some catches for the weird characters. But looks like your file is clean, with none of that issue. I sorta assumed all the files would come this way.