search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.22k stars 177 forks source link

[feature request] image name input and output #222

Closed Kiaazad closed 1 year ago

Kiaazad commented 1 year ago

Save image node is a pretty handy tool, it is a bit tricky to sync two of it to save files with the same name though. It would be great if you add image name output and inputs so I can have one make the image name and the other copy it.

WASasquatch commented 1 year ago

Image node can't have outputs or it breaks image viewing. Not sure why. I guess cause it's an Output Node type.

Kiaazad commented 1 year ago

How about just the name input, maybe we can handle the naming with a primitive node? I'm not sure if the node has to check the other files in the folder before naming the file, maybe we can have a counter with some string function to generate a new name on each queue, then pass it to two image save nodes.

WASasquatch commented 1 year ago

How about just the name input, maybe we can handle the naming with a primitive node? I'm not sure if the node has to check the other files in the folder before naming the file, maybe we can have a counter with some string function to generate a new name on each queue, then pass it to two image save nodes.

I think you're looking for the prefix_as_filename overwrite mode?

image

Kiaazad commented 1 year ago

Oh, I assumed overwrite mode is for overwriting the files. With a counter it works almost flawlessly. The only hurdle I have is the counter resets and overwrites files when I relaunch comfyui. image Do you know of any node to check the folder and start the name right after the latest file? The save nodes seem to handle that part, maybe that functionality alongside setting folder names can be isolated? Or better, a node that saves multiple images in different folders but with the same name?

WASasquatch commented 1 year ago

I don't. That's sorta the point of the prefix system is it detects that and continues. You can define how many leading zeros it has, as well as if it starts at end of beginning of filename_prefix

On Fri, Sep 29, 2023, 11:02 PM Kia Azad @.***> wrote:

Oh, I assumed overwrite mode is for overwriting the files. With a counter it works almost flawlessly. The only hurdle I have is the counter resets and overwrites files when I relaunch comfyui. [image: image] https://user-images.githubusercontent.com/33455007/271756717-8d1e9a28-c40f-446b-913e-5f1feef87f90.png Do you know of any node to check the folder and start the name right after the latest file? The save nodes seem to handle that part, maybe that functionality alongside setting folder names can be isolated? Or better, a node that saves multiple images in different folders but with the same name?

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/222#issuecomment-1741689424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZJ2Q7M7JRGVFDZD5FDX46YY5ANCNFSM6AAAAAA5MJHYKA . You are receiving this because you commented.Message ID: @.***>

Kiaazad commented 1 year ago

Thank you, I think we can close this issue. What do you think about the multi file save node idea? Is it feasible? Should I suggest it in a new issue?

WASasquatch commented 1 year ago

Multiple paths might be doable. I'll have to look to see how best to incorporate it if not another node.

WASasquatch commented 1 year ago

Multiple paths might be doable. I'll have to look to see how best to incorporate it if not another node. Feel free to make a discussion request so I don't forget.