search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

WAS_random_number : add shuffled list of integers. Fix boolean. #224

Closed willsmithorg closed 1 year ago

willsmithorg commented 1 year ago

Hi

I hope you'll consider my pull request. This adds a list of random integers e.g. if min=1, max=4 then you may get the string "4,2,1,3" as output.

Also I fixed up boolean so it returns integer 0 with 50% probability and 1 with 50% probability. Previously it always returned 0 because int() rounds downwards.

WASasquatch commented 1 year ago

I'm a little confused as to the purpose of outputting a string list of integers? Shouldn't it be using IS_LIST_OUTPUT and returning a list of integers? Don't see a reason to not add it though as it is it's own mode, so I'm fine with it.