WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.24k stars 178 forks source link

Add bus node. This is going to be very popular. #227

Closed willsmithorg closed 1 year ago

willsmithorg commented 1 year ago

This greatly reduces connectors. I think it's going to be very popular. I will probably eventually submit it to core ComfyUI, but right now he has so many outstanding PRs I don't think he'll notice mine.

I stuck an example workflow on your wiki page: https://github.com/WASasquatch/was-node-suite-comfyui/wiki/Workflow-Examples#bus-download

I designed this in my head over a few days, and it was actually trivial to implement :)

willsmithorg commented 1 year ago

One thing I can't work out - how to do the javascript so the suggestion when you drag from the "bus" output, is another bus node. I can see that 'reroute' does this via javascript. Would be great if you could help me add this.

WASasquatch commented 1 year ago

One thing I can't work out - how to do the javascript so the suggestion when you drag from the "bus" output, is another bus node. I can see that 'reroute' does this via javascript. Would be great if you could help me add this.

I am very bad with the front end. I still can't fathom how that's supposed to be an API to build from. Unmapped arrays, constants everywhere, it's really confusing to me.