WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Enhance replace_wildcards Function with Caching for Duplicate Prevention and additional randomness. #228

Closed toxicwind closed 11 months ago

toxicwind commented 12 months ago

This commit significantly improves the replace_wildcards function with a focus on performance and duplicate prevention. The key enhancements are as follows:

These changes make the replace_wildcards function more efficient and robust, particularly in scenarios where preventing recent duplicates is crucial.

toxicwind commented 12 months ago

This should be deterministic and prevent duplicates, unlike the last one.

WASasquatch commented 12 months ago

Wouldn't caching prevent users from getting updates to their wildcards? A lot of people, myself included edit those files often. For example if I setup a custom scene wildcard to use for a specific task I often tweak weighting or add some additional stuff.

toxicwind commented 11 months ago

That is indeed a good point. I'm going to keep this as a patch for myself as I don't generally do that, but totally get it.