WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Can't save WebP #232

Open albamuth opened 11 months ago

albamuth commented 11 months ago

Getting the error:

WAS Node Suite Error: Unable to save file due to the to the following error:
'PngInfo' object has no attribute 'startswith'

WAS node filewrite webp error

Switching to any other format works fine, however. I wasn't getting this issue two days ago. I just updated everything and tried it again just before posting this.

WASasquatch commented 11 months ago

What is the full error in the console? .startswith isn't even use in the block where that error originates so that is confusing. Nor is metadata ever passed to anything that uses .startswith

albamuth commented 11 months ago

That was the full error. Here's another example of the error, with a completely different workflow.


0: 640x448 1 face, 20.0ms
Speed: 2.0ms preprocess, 20.0ms inference, 2.0ms postprocess per image at shape (1, 3, 640, 448)
semd to cuda:0
Detailer: segment upscale for ((119.814026, 155.95409)) | crop region (179, 233) x 2.13664467179105 -> (382, 497)
100%|█████████████████████████████████████████████████████████████████████████████████| 30/30 [00:14<00:00,  2.01it/s]
WAS Node Suite Error: Unable to save file due to the to the following error:
'PngInfo' object has no attribute 'startswith'
Prompt executed in 221.61 seconds

WAS node filewrite webp error 2

TG SD1.5 style swapper 0.1.json As you can see, the image is coming out of FaceDetailer.

VinsiGit commented 11 months ago

I also have this problem, someone said the node is throwing the PngInfo object at the WebP encoder as the Exif parameter

WASasquatch commented 11 months ago

https://github.com/WASasquatch/was-node-suite-comfyui/commit/802acadd8a2abc120c7623c2e8fb2afb7b536e6c

If you have https://github.com/Kaharos94/ComfyUI-Saveaswebp you can load from webp workflow now. SaveWebp

VinsiGit commented 11 months ago

This is great, but, does this node solve problem the save a image as a .webp with your node because I need the custom path and name?

WASasquatch commented 11 months ago

Well that's a webp file I am demonstrating, so yes, it's saving a webp

WAS-NS currently is exclusively backend, so to import the webp it saves you need that custom node.

VinsiGit commented 11 months ago

it works thx