search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

opencv-python version issues #251

Open BuffMcBigHuge opened 11 months ago

BuffMcBigHuge commented 11 months ago

The requirements.txt installs opencv-python-headless[ffmpeg]<=4.7.0.72 which seems to break other nodes, such as comfyui-reactor-node, as per this issue.

Is there a reason for forcing a lower version of opencv-python?

WASasquatch commented 11 months ago

The requirements.txt installs opencv-python-headless[ffmpeg]<=4.7.0.72 which seems to break other nodes, such as comfyui-reactor-node, as per this issue.

Is there a reason for forcing a lower version of opencv-python?

You can probably remove that, though specific video nodes may not function correctly. I think there was deprecated stuff that wasn't covered yet in documentation so I wasn't sure what the alternative was.

vincenzoml commented 9 months ago

if I just run pip install opencv-python-headless[ffmpeg] then I get Cannot import /repos/ComfyUI/custom_nodes/was-node-suite-comfyui module for custom nodes: module 'cv2.dnn' has no attribute 'DictValue'. If I don't install anything related to opencv-python, then WAS suite will install it correctly. Don't exactly know what's going on.

WASasquatch commented 9 months ago

Something else may be enforcing a opencv version (which would be weird). Additionally, the latest ffmpeg opencv may have changes, meaning you need to use an older version.

For example, the versions I have on a relatively newer nightly of ComfyUI is:

On Wed, Dec 13, 2023 at 6:33 AM Vincenzo Ciancia @.***> wrote:

if I just run pip install opencv-python-headless[ffmpeg] then I get Cannot import /repos/ComfyUI/custom_nodes/was-node-suite-comfyui module for custom nodes: module 'cv2.dnn' has no attribute 'DictValue'. If I don't install anything related to opencv-python, then WAS suite will install it correctly. Don't exactly know what's going on.

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/251#issuecomment-1854029294, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZNL4ZLGFSYJICSJ34TYJG4FFAVCNFSM6AAAAAA6OGXFAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJUGAZDSMRZGQ . You are receiving this because you commented.Message ID: @.***>

-- Sincerely, Jordan S. C. Thompson