search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Image Save #252

Open alexbofa opened 11 months ago

alexbofa commented 11 months ago

Hello I have problem, I use same workflow with other nodes: image

Loading 2 new models
100%|██████████████████████████████████████████████████████████████████████████████████| 35/35 [25:16<00:00, 43.33s/it]
WAS Node Suite: 00001 Index: 1
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
Prompt executed in 1607.32 seconds
Error handling request
Traceback (most recent call last):
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_app.py", line 504, in _handle
    resp = await handler(request)
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
    return await handler(request)
  File "X:\ComfyUI\ComfyUI\server.py", line 46, in cache_control
    response: web.Response = await handler(request)
  File "X:\ComfyUI\ComfyUI\server.py", line 270, in view_image
    if os.path.commonpath((os.path.abspath(full_output_dir), output_dir)) != output_dir:
  File "ntpath.py", line 804, in commonpath
ValueError: Paths don't have the same drive
Error handling request
Traceback (most recent call last):
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_app.py", line 504, in _handle
    resp = await handler(request)
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
    return await handler(request)
  File "X:\ComfyUI\ComfyUI\server.py", line 46, in cache_control
    response: web.Response = await handler(request)
  File "X:\ComfyUI\ComfyUI\server.py", line 270, in view_image
    if os.path.commonpath((os.path.abspath(full_output_dir), output_dir)) != output_dir:
  File "ntpath.py", line 804, in commonpath
ValueError: Paths don't have the same drive

Why don't other images want to be saved?

alexbofa commented 11 months ago 
WAS Node Suite: 00001 Index: 1
WAS Node Suite: 00001 Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.37it/s]
Prompt executed in 11.87 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite: 00001 Index: 1
WAS Node Suite: 00001 Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.36it/s]
Prompt executed in 11.93 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite: 00001 Index: 1
WAS Node Suite: 00001 Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.43it/s]
Prompt executed in 11.65 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite: 00001 Index: 1
WAS Node Suite: 00001 Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.42it/s]
Prompt executed in 11.65 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite: 00001 Index: 1
WAS Node Suite: 00001 Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.36it/s]

I don't know why, but I only started rendering the frame 00001

Prompt executed in 11.76 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite:  Index: 1
WAS Node Suite:  Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.26it/s]
Prompt executed in 12.07 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite:  Index: 1
WAS Node Suite:  Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.44it/s]
Prompt executed in 11.46 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite:  Index: 1
WAS Node Suite:  Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.35it/s]
Prompt executed in 11.64 seconds

I think problem in masquerade-nodes Cut by mask, but what can break the previous nodes? image

WASasquatch commented 11 months ago 
WAS Node Suite: 00001 Index: 1
WAS Node Suite: 00001 Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.37it/s]
Prompt executed in 11.87 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite: 00001 Index: 1
WAS Node Suite: 00001 Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.36it/s]
Prompt executed in 11.93 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite: 00001 Index: 1
WAS Node Suite: 00001 Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.43it/s]
Prompt executed in 11.65 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite: 00001 Index: 1
WAS Node Suite: 00001 Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.42it/s]
Prompt executed in 11.65 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite: 00001 Index: 1
WAS Node Suite: 00001 Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.36it/s]

I don't know why, but I only started rendering the frame 00001

Prompt executed in 11.76 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite:  Index: 1
WAS Node Suite:  Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.26it/s]
Prompt executed in 12.07 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite:  Index: 1
WAS Node Suite:  Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.44it/s]
Prompt executed in 11.46 seconds
Prompt executor has been patched by Job Iterator!
WAS Node Suite:  Index: 1
WAS Node Suite:  Index: 1
100%|████████████████████████████████████████████████████████████| 35/35 [00:10<00:00,  3.35it/s]
Prompt executed in 11.64 seconds

I think problem in masquerade-nodes Cut by mask, but what can break the previous nodes? image

Prompt execution being patched may be preventing proper iterations of prompt queue.

Hello I have problem, I use same workflow with other nodes: image

Loading 2 new models
100%|██████████████████████████████████████████████████████████████████████████████████| 35/35 [25:16<00:00, 43.33s/it]
WAS Node Suite: 00001 Index: 1
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
WAS Node Suite: Image file saved to: X:\out\img2img_upscale_key\00001.png
Prompt executed in 1607.32 seconds
Error handling request
Traceback (most recent call last):
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_app.py", line 504, in _handle
    resp = await handler(request)
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
    return await handler(request)
  File "X:\ComfyUI\ComfyUI\server.py", line 46, in cache_control
    response: web.Response = await handler(request)
  File "X:\ComfyUI\ComfyUI\server.py", line 270, in view_image
    if os.path.commonpath((os.path.abspath(full_output_dir), output_dir)) != output_dir:
  File "ntpath.py", line 804, in commonpath
ValueError: Paths don't have the same drive
Error handling request
Traceback (most recent call last):
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_app.py", line 504, in _handle
    resp = await handler(request)
  File "X:\ComfyUI\python_embeded\lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
    return await handler(request)
  File "X:\ComfyUI\ComfyUI\server.py", line 46, in cache_control
    response: web.Response = await handler(request)
  File "X:\ComfyUI\ComfyUI\server.py", line 270, in view_image
    if os.path.commonpath((os.path.abspath(full_output_dir), output_dir)) != output_dir:
  File "ntpath.py", line 804, in commonpath
ValueError: Paths don't have the same drive

Why don't other images want to be saved?

It seems Comfy is trying to enforce images to be on the same drive and in output for now, from what I gather. Which is not cool.

alexbofa commented 11 months ago

This workflow also worked before, now the same problem.

Screen-2671

Prompt executed in 4.38 seconds
WAS Node Suite: 00001 Index: 2
Prompt executed in 3.03 seconds
WAS Node Suite: 00001 Index: 3
Prompt executed in 2.64 seconds
WAS Node Suite: 00001 Index: 4
Prompt executed in 2.86 seconds
WAS Node Suite: 00001 Index: 5
Prompt executed in 2.64 seconds
WAS Node Suite: 00001 Index: 6
Prompt executed in 2.66 seconds
WAS Node Suite: 00001 Index: 7
Prompt executed in 2.65 seconds
WAS Node Suite: 00001 Index: 8
Prompt executed in 2.68 seconds
WAS Node Suite: 00001 Index: 9
Prompt executed in 2.66 seconds
WAS Node Suite: 00001 Index: 10
Prompt executed in 2.64 seconds
WAS Node Suite: 00001 Index: 11
Prompt executed in 2.65 seconds
WAS Node Suite: 00001 Index: 12
Prompt executed in 2.66 seconds
WAS Node Suite: 00001 Index: 13
Prompt executed in 2.65 seconds
WAS Node Suite: 00001 Index: 14
Prompt executed in 2.85 seconds
WAS Node Suite: 00001 Index: 15
Prompt executed in 2.69 seconds
WAS Node Suite: 00001 Index: 16
Prompt executed in 2.96 seconds
WAS Node Suite: 00001 Index: 17
Prompt executed in 2.82 seconds
WAS Node Suite: 00001 Index: 18
Prompt executed in 2.82 seconds
WAS Node Suite: 00001 Index: 19
Prompt executed in 2.74 seconds
WAS Node Suite: 00001 Index: 20
Prompt executed in 2.68 seconds
WAS Node Suite: 00001 Index: 21
Prompt executed in 2.73 seconds
WAS Node Suite: 00001 Index: 22
Prompt executed in 2.77 seconds
WAS Node Suite: 00001 Index: 0
Prompt executed in 2.78 seconds
WASasquatch commented 11 months ago

I am not sure that the issue is. All my nodes send is a IMAGE tensor. It sounds like this problem is with ComfyUI. Perhaps a script you have installed.

On Fri, Oct 27, 2023, 4:36 AM alexbofa @.***> wrote:

This workflow also worked before, now the same problem.

[image: Screen-2671] https://user-images.githubusercontent.com/58225118/278629860-09779b51-3cd1-40b4-9269-40c79242ba64.png

Prompt executed in 4.38 seconds WAS Node Suite: 00001 Index: 2Prompt executed in 3.03 seconds WAS Node Suite: 00001 Index: 3Prompt executed in 2.64 seconds WAS Node Suite: 00001 Index: 4Prompt executed in 2.86 seconds WAS Node Suite: 00001 Index: 5Prompt executed in 2.64 seconds WAS Node Suite: 00001 Index: 6Prompt executed in 2.66 seconds WAS Node Suite: 00001 Index: 7Prompt executed in 2.65 seconds WAS Node Suite: 00001 Index: 8Prompt executed in 2.68 seconds WAS Node Suite: 00001 Index: 9Prompt executed in 2.66 seconds WAS Node Suite: 00001 Index: 10Prompt executed in 2.64 seconds WAS Node Suite: 00001 Index: 11Prompt executed in 2.65 seconds WAS Node Suite: 00001 Index: 12Prompt executed in 2.66 seconds WAS Node Suite: 00001 Index: 13Prompt executed in 2.65 seconds WAS Node Suite: 00001 Index: 14Prompt executed in 2.85 seconds WAS Node Suite: 00001 Index: 15Prompt executed in 2.69 seconds WAS Node Suite: 00001 Index: 16Prompt executed in 2.96 seconds WAS Node Suite: 00001 Index: 17Prompt executed in 2.82 seconds WAS Node Suite: 00001 Index: 18Prompt executed in 2.82 seconds WAS Node Suite: 00001 Index: 19Prompt executed in 2.74 seconds WAS Node Suite: 00001 Index: 20Prompt executed in 2.68 seconds WAS Node Suite: 00001 Index: 21Prompt executed in 2.73 seconds WAS Node Suite: 00001 Index: 22Prompt executed in 2.77 seconds WAS Node Suite: 00001 Index: 0Prompt executed in 2.78 seconds

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/252#issuecomment-1782763298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZPVE64O5XRP535LBBTYBOMD3AVCNFSM6AAAAAA6PXDLHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSG43DGMRZHA . You are receiving this because you commented.Message ID: @.***>

alexbofa commented 11 months ago

so far, but I don't understand the problem, while I'm writing what I know. I don't know where to turn yet and how to solve it)

WASasquatch commented 11 months ago

Can you check your browser console log for script errors with the front end? Maybe there is something there I can pass along to comfy.

On Fri, Oct 27, 2023, 8:53 AM alexbofa @.***> wrote:

so far, but I don't understand the problem, while I'm writing what I know. I don't know where to turn yet and how to solve it)

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/252#issuecomment-1783146659, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZMYCJN6ZF3WWWAFSLDYBPKIHAVCNFSM6AAAAAA6PXDLHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGE2DMNRVHE . You are receiving this because you commented.Message ID: @.***>

alexbofa commented 8 months ago

This console? image

WASasquatch commented 8 months ago

You are driving to save to another drive when comfy locks down the directory to ensure it's same drive and root path to output for

On Mon, Jan 8, 2024, 7:58 AM alexbofa @.***> wrote:

This console? image.png (view on web) https://github.com/WASasquatch/was-node-suite-comfyui/assets/58225118/37cd7d99-0375-49d6-b785-d364416c2ab0

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/252#issuecomment-1881352891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZN3OPBRARJ7GFBFYH3YNQJT5AVCNFSM6AAAAAA6PXDLHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRGM2TEOBZGE . You are receiving this because you commented.Message ID: @.***>

alexbofa commented 8 months ago

Hm, what should I do in this case, who should I write to, how should I fix it?

Since --output-directory is written in run_nvidia_gpu.bat for example X:\Stable-Diffusion\output\ComfyUI, and I save other projects in X:\Stable-Diffusion\output\Projects is there a conflict over this? Also this path is a symlink X:\Stable-Diffusion\output since images are uploaded from this folder to the cloud drive.

WASasquatch commented 8 months ago

It may be the symlinks, as I have my output directory on D, while portable is on C drive.

On Mon, Jan 8, 2024, 11:02 AM alexbofa @.***> wrote:

Hm, what should I do in this case, who should I write to, how should I fix it?

Since --output-directory is written in run_nvidia_gpu.bat for example X:\Stable-Diffusion\output\ComfyUI , and I save other projects in X:\Stable-Diffusion\output\Projects is there a conflict over this? Also this path is a symlink X:\Stable-Diffusion\output since images are uploaded from this folder to the cloud drive.

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/252#issuecomment-1881658596, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZKFDZQIWDKVVWKD4ILYNQ7CZAVCNFSM6AAAAAA6PXDLHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRGY2TQNJZGY . You are receiving this because you commented.Message ID: @.***>