WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Request to update support for Numpy==1.26 #263

Open ZTWY35 opened 10 months ago

ZTWY35 commented 10 months ago

My Comfyui always automatically updates Numpy to version 1.26 every time it starts up, but was-node-suite-comfyui only supports up to version 1.24, which conflicts.I hope it can be updated to support Numpy==1.26.Thank you.

WASasquatch commented 10 months ago

Remove the pinned version from requirements. I don't even remember what needed numpy so low. Probably blip which needs old transformers. But you should be fine unless you run into that one node that does need it.

cardenluo commented 8 months ago

was-node-suite-comfyui module for custom nodes: Numba needs NumPy 1.24 or less 。

Once I upgrade other plugins, there are still errors.

WASasquatch commented 8 months ago

Naturally, when something like WAS-NS needs to downgrade dependencies, you install it last. If you upgrade other plugins, they run their requirements, and upgrade deps. So the lower versions, like numpy, transformers, etc get upgraded often.