WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
945 stars 144 forks source link

comfyui was updated, which makes WNS unsuitable for it #270

Open godlockin opened 7 months ago

godlockin commented 7 months ago

https://github.com/comfyanonymous/ComfyUI/blob/eb0407e80657ab603a1251a653ad8b2e9e89c83c/comfy/model_management.py#L241C27-L241C33

by invoking the method, the following error would raised:

Error occurred when executing Text Multiline:

get_torch_device_name() missing 1 required positional argument: 'device'

File "/ComfyUI/execution.py", line 153, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "/ComfyUI/execution.py", line 83, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "/ComfyUI/execution.py", line 76, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "/ComfyUI/custom_nodes/was-node-suite-comfyui/WAS_Node_Suite.py", line 9444, in text_multiline
tokens = TextTokens()
File "/ComfyUI/custom_nodes/was-node-suite-comfyui/WAS_Node_Suite.py", line 835, in __init__
'[cuda_name]': comfy.model_management.get_torch_device_name(),
montyfi commented 7 months ago

Have the same issue

GalaxyTimeMachine commented 7 months ago

Just checked in to report the same problem.

alenknight commented 7 months ago

same issue here

WeeBull commented 7 months ago

This was a WAS suite change, not a ComfyUI one. https://github.com/WASasquatch/was-node-suite-comfyui/commit/75396f76af68f501d703ff1c0ecde95c983af684

Takeover713 commented 7 months ago

Im getting the same error

sh1ny commented 7 months ago

Can confirm, all goes boom.

WASasquatch commented 7 months ago

This should have already been patched moments after the initial patch. Weird. I guess git failed to push (I have sat net)

WASasquatch commented 7 months ago

Confirming patch here: https://github.com/WASasquatch/was-node-suite-comfyui/commit/4e53775e650a7e2d2d1d73056bb914d7edc57f69

Takeover713 commented 7 months ago

thank you!