search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Save image node sudenly stopped working. #284

Closed mpvfx closed 10 months ago

mpvfx commented 10 months ago

After an update to comfyui and all extensions, the save image node stop working throwing the following error:

Error occurred when executing Image Save:

get_torch_device_name() missing 1 required positional argument: 'device'

File "X:\ComfyUI_windows_portable\ComfyUI\execution.py", line 153, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "X:\ComfyUI_windows_portable\ComfyUI\execution.py", line 83, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "X:\ComfyUI_windows_portable\ComfyUI\execution.py", line 76, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui-------\WAS_Node_Suite.py", line 7108, in was_save_images tokens = TextTokens() ^^^^^^^^^^^^ File "X:\ComfyUI_windows_portable\ComfyUI\custom_nodes\was-node-suite-comfyui-------\WAS_Node_Suite.py", line 835, in init '[cuda_name]': comfy.model_management.get_torch_device_name(), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I've updated everything, same problem, tried uninstalling and re-installing, nope, same error. Any help will be greatly appreciated! Thanks in advance!

mpvfx commented 10 months ago

well this is embarrassing!

Turns out, for some reason, I had 2 folders of was-node-suite-comfyui in the custom node folder, the second (was-node-suite-comfyui-------) was the culprit. Deleted it and all is good. Sorry all.

WASasquatch commented 10 months ago

Least it was an easy find. I hate when stuff like that eludes you forever and then when you find it, seemed so obvious, and then you feel silly. Lol

mpvfx commented 10 months ago

So True! Thanks for my favorite set of nodes by the way!

On Sat, Nov 25, 2023 at 8:14 PM WAS @.***> wrote:

Least it was an easy find. I hate when stuff like that eludes you forever and then when you find it, seemed so obvious, and then you feel silly. Lol

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/284#issuecomment-1826390737, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEH3R7AV4LQ7VIEFIM6HZ2DYGIYRLAVCNFSM6AAAAAA72HPKY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGM4TANZTG4 . You are receiving this because you modified the open/close state.Message ID: @.***>