search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

feat: option to disable whitespace cleanup in "Text Concatenate" #311

Closed Arcitec closed 9 months ago

Arcitec commented 9 months ago

Closes #310

This new feature makes it possible to keep all messy whitespace that comes into the text concatenation node. Most people won't want this, so it's off by default.

It also makes the node's UI a bit more cluttered with 1 extra option, which isn't even useful at all for Stable Diffusion (since SD doesn't care at all about whitespace).

But there's one usage for it: Manually creating "pretty formatted" text strings for debug printing to the console. Is it worth adding a whole option to the node and making the UI "bigger" just for that? I don't really think so, but it's not my call to make, and it was requested by at least 1 person who has a usage case for it! :)

Edit: See next message for a screenshot of the new mode.

Arcitec commented 9 months ago

Here is a demonstration of the new option:

2023-12-27_17-14

WASasquatch commented 9 months ago

Roger Roger :]

Looks good. Love the work you have put into making more effective functionality out of these.

Arcitec commented 9 months ago

@WASasquatch No worries. Hope you have a nice new year's! :)