WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.22k stars 177 forks source link

Image Rotate Hue Node #318

Open daniel-lewis-ab opened 10 months ago

daniel-lewis-ab commented 10 months ago

Problems:

So I wasn't able to decipher how best to use this node, as it just provides a Number interface and I couldn't find an example usage. I tried getting it to rotate by 255, by -20, by -0.1, and those all seemed to silently fail with a purple border rather than simply not letting me get to that range via comfy's provided bounds definitions.

At 0.08, I got the following message:

image

Solutions:

I would suggest setting the bounds checking for Numbers for this node, and perhaps any others you fancy: image

You may also opt to set it to a slider at your discretion, or look into that work someone was doing on implementing color as a type within Comfy.

Thanks for all your work m8.

WASasquatch commented 10 months ago

ComfyUI doesn't have working sliders.

And seems you are giving it a batch, while it works on single images?

daniel-lewis-ab commented 10 months ago

Thanks for your reply.

Okay, I'll adjust my usage for a single image and use autoqueue and an iterator to do my batch.

What range does it expect as input?

Also, you could probably still set range boundaries on the number.

Thanks again.

On Thu., Jan. 4, 2024, 09:36 WAS, @.***> wrote:

ComfyUI doesn't have working sliders.

And seems you are giving it a batch, while it works on single images?

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/318#issuecomment-1877410369, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC36LN5WAW4TNDVJ2IMYVDTYM3LBXAVCNFSM6AAAAABBNF7AFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGQYTAMZWHE . You are receiving this because you authored the thread.Message ID: @.***>

WASasquatch commented 10 months ago

It should be 0-1.0. Where 0 is no rotation, and 1.0 is full rotation (so no change either I believe, as you've rotated back to start

FYI there is a node suite that I can't remember the name of that has a Images to List feature where it'll make the node run for each element in list, then you can convert back to a image batch after.