WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

WAS_VAE_Input_Switch.vae_switch() got an unexpected keyword argument 'boolean_number' #364

Open adrian-forest opened 6 months ago

adrian-forest commented 6 months ago

Error from VAE Input Switch:

`Error occurred when executing VAE Input Switch:

WAS_VAE_Input_Switch.vae_switch() got an unexpected keyword argument 'boolean_number'

File "E:\stable\ComfyUI\execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "E:\stable\ComfyUI\execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "E:\stable\ComfyUI\execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))`

adrian-forest commented 6 months ago

A probably very bad workaround? #365

wandrzej commented 6 months ago

the latest update seems to have messed up the variable types in switches - I had workflows that used NUMBER as input, and now it seems it's not going to work anymore. Wonder what's the plan for those switch nodes?

Ionaut commented 6 months ago

Check these in custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py image

nachocheeseburger commented 6 months ago

Check these in custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py image

sorry for being noob but what do we change here?

Pos13 commented 6 months ago

Check these in custom_nodes\was-node-suite-comfyui\WAS_Node_Suite.py

That breaks sharing your workflow with others. It's such a minor fix, I hope it will be implemented soon.

adrian-forest commented 6 months ago

It's been almost a month since the last commit, and I don't love the idea of people using my janky hack code as a workaround, so hopefully this can get some attention soon!

Pos13 commented 5 months ago

Speaking of jank hacks: as a temorary workaround, you can cast number to text and compare it to "1" to get a BOOLEAN. image

WAS-PlaiLabs commented 4 months ago

image

https://github.com/WASasquatch/was-node-suite-comfyui/commit/7fb076611b4779e3943aa04925577c9e687653c7