search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.22k stars 177 forks source link

add kwargs argument as a workaround to ignore boolean_number arguments #365

Open adrian-forest opened 8 months ago

adrian-forest commented 8 months ago

add kwargs argument as a workaround to ignore boolean_number arguments passed to the function

I encountered and reported #364 . This change seems to avoid this error on my local.

I know that this is BAD CODE! I'm a .NET developer by trade, but I could navigate python enough to identify this workaround, but I also know enough to assume it's VERY BAD and DOES NOT ACTUALLY SOLVE THE PROBLEM. However, this does avoid the error on my local, so far as I can tell, and I'm hoping maybe a PR might prompt somebody to make a proper fix?

Honestly, this is my first time making a PR to a public repo, so please be nice?

WAS-PlaiLabs commented 6 months ago

This may not be needed now as per https://github.com/WASasquatch/was-node-suite-comfyui/commit/7fb076611b4779e3943aa04925577c9e687653c7