search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.22k stars 177 forks source link

Random mode on Load Image Batch keeps choosing the same images #379

Open Tromazing opened 7 months ago

Tromazing commented 7 months ago

I've set up a Load Image Batch node to select from a few hundred different images in several subfolders, using the "*/**" pattern and Random mode. But around 8 out of 10 that come up are the same few on rotation. What could be causing this and is there a way around it?

WAS-PlaiLabs commented 6 months ago

random is incredibly un-random, is really the issue likely. In ComfyUI you'll notice if you select from a range of numbers you get the same repeated vales all the time. The best way around that is simply a better random number generator.

I can't see anything wrong with the code. It simply grabs a random number between 0 and the number of images detected, and selects a random index.

qirtn commented 3 weeks ago

I think the load_batch_images function needs a seed. I added random.seed() before the line where it picks a random number and it started loading a random image everytime.

WASasquatch commented 3 weeks ago

If you want to PR that change we can add it. Maybe expose the seed value with seed widget?