[BUG] - Workflow breaking issue, { } is scraped out from string when passed through your node!

[RamonGuthrie]

Hi as reported here https://github.com/comfyanonymous/ComfyUI/issues/3302

Screenshot

I've tried everything, including reinstalling ComfyUI, but the problem persists. Can this issue be fixed?

[WAS-PlaiLabs]

{a|b|c} would result in a random value of those, as that's how dynamic prompts work in ComfyUI. Same for CLIPTextEncode.

[RamonGuthrie]

{a|b|c}

{a|b|c} does not result in a random value anymore in CLIPTextEncode

[WAS-PlaiLabs]

Ofc it does. Otherwise it would have 'dynamicPrompts': False as part of the multiline options. This is base ComfyUI behavior for any multiline text field without explicitly disabling it.

[RamonGuthrie]

Ofc it does. Otherwise it would have 'dynamicPrompts': False as part of the multiline options. This is base ComfyUI behavior for any multiline text field without explicitly disabling it.

What I meant {a|b|c} does not result in a random value when using a WAS text node to achieve a similar thing and now there seems to be a bug in Comfy with the CLIP Text Encode, try it "Convert text to input" then convert text back to a widget, it breaks the outputs!

[WAS-PlaiLabs]

It did, and I just removed that ability by disabling "dynamicPrompts": False in latest PR. Regarding regular CLIPTextEncode, it works fine when I convert inputs, and I do that regularly every day, so you likely have Front-End custom nodes that weren't put together well breaking your system. I do not suggest use, nor support any third-party JavaScript in ComfyUI because of how it's implemented. Inherently prone to issues across custom nodes and base system. That's why you'll find no JS in WAS-NS. It needs to work headless or with a GUI.

[RamonGuthrie]

It did, and I just removed that ability by disabling "dynamicPrompts": False in latest PR. Regarding regular CLIPTextEncode, it works fine when I convert inputs, and I do that regularly every day, so you likely have Front-End custom nodes that weren't put together well breaking your system. I do not suggest use, nor support any third-party JavaScript in ComfyUI because of how it's implemented. Inherently prone to issues across custom nodes and base system. That's why you'll find no JS in WAS-NS. It needs to work headless or with a GUI.

Thanks for looking at this, I'll load one of my old workflows and see if it fixes the problem

[fabvlator]

Hola there,

Just find out that "Text Multiline" also has the dynamicPrompts set to False. There is another "false", but not sure if affects other widget.

Hope this is of little help. Thanks for your work. /btw I mentioned this in the Comfy #3302 , I also made a small request looking to find a way to resolve this kind of situations, just in case people want to check and give their feedback or provide better ideas.

\WAS_Node_Suite.py

(_Text Multiline)_
Line  9507:     "text": ("STRING", {"default": '', "multiline": True, **"dynamicPrompts": False}),**

_(not sure about this one)_
Line 11056:     "question": ("STRING", {"default": "What does the background consist of?", "multiline": True, **"dynamicPrompts": False}),**

[WASasquatch]

I have it disabled on purpose, so it can be used with code and stuff where {} is often used.

On Sat, May 18, 2024, 2:13 AM fabvlator @.***> wrote:

Hola there,

Just find out that "Text Multiline" also has the dynamicPrompts set to False. There is another "false", but not sure if affects other widget.

Hope this is of little help. Thanks for your work.

\WAS_Node_Suite.py

(Text Multiline) Line 9507: "text": ("STRING", {"default": '', "multiline": True, "dynamicPrompts": False}),

(not sure about this one) Line 11056: "question": ("STRING", {"default": "What does the background consist of?", "multiline": True, "dynamicPrompts": False}),

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/383#issuecomment-2118727283, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZPC2MARVU2YAZNG3DLZC4LVHAVCNFSM6AAAAABGPQYSWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYG4ZDOMRYGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>