WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.23k stars 178 forks source link

What does `index` parameter in `Load Image Batch` node mean??? #389

Open zerobell-lee opened 7 months ago

zerobell-lee commented 7 months ago

I was making images in batch processes, and I rebooted my PC for some reason. And I got the batch index reset.

Even though I tried specifying index parameter, such as 124. it didn't work. It starts with 0 again.

image

So I investigated source code.

    class BatchImageLoader:
        def __init__(self, directory_path, label, pattern):
            self.WDB = WDB
            self.image_paths = []
            self.load_images(directory_path, pattern)
            self.image_paths.sort()
            stored_directory_path = self.WDB.get('Batch Paths', label)
            stored_pattern = self.WDB.get('Batch Patterns', label)
            if stored_directory_path != directory_path or stored_pattern != pattern:
                self.index = 0
                self.WDB.insert('Batch Counters', label, 0)
                self.WDB.insert('Batch Paths', label, directory_path)
                self.WDB.insert('Batch Patterns', label, pattern)
            else:
                self.index = self.WDB.get('Batch Counters', label)
            self.label = label

it even does not use index parameter in the loader. Only when I'm doing continuous task at the same environment, I can get indices sequential. So there is no way to start with specific index.

Then, what is index parameter standing for?

WAS-PlaiLabs commented 7 months ago

Did, you, like try changing the mode to single_image? hehe

        if mode == 'single_image':
            image, filename = fl.get_image_by_id(index)
            if image == None:
                cstr(f"No valid image was found for the inded `{index}`").error.print()
                return (None, None)
holycowdude commented 1 week ago

After updating Comfui Portable and WAS Node Suite my "load image batch" has stopped working, it worked previously

In INDEX it says 'NaN' When I press queue I get an error:

_Prompt outputs failed validation Load Image Batch:

I simply use it as a batch loader to batch process images for upscale

Please can someone help? thanks

WAS-PlaiLabs commented 1 week ago

NaN would be a invalid input, so you need to change that to a valid index like 0 for first element. Seems the node has changed on your and your widget inputs got mixed up.

On Wed, Nov 20, 2024, 7:43 AM holycowdude @.***> wrote:

After updating Comfui Portable and WAS Node Suite my "load image batch" has stopped working, it worked previously

In INDEX it says 'NaN' When I press queue I get an error:

_Prompt outputs failed validation Load Image Batch:

  • Failed to convert an input value to a INT value: index, None, int() argument must be a string, a bytes-like object or a real number, not 'NoneType'_

If I change the INDEX to a number I get an error "Index out of range" ComfyUI Error Report Error Details

  • Node ID: 109
  • Node Type: Load Image Batch
  • Exception Type: IndexError
  • Exception Message: list index out of range

Stack Trace

I simply use it as a batch loader to batch process images for upscale

Please can someone help? thanks

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/389#issuecomment-2488929359, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGIZLDON3B72B636M2ELNF32BSUZ5AVCNFSM6AAAAABSE4MJJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBYHEZDSMZVHE . You are receiving this because you commented.Message ID: @.***>

holycowdude commented 6 days ago

If anyone has this problem in future, right click and select fix node