search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

About stacking LORAS #391

Closed alonsojr1980 closed 5 months ago

alonsojr1980 commented 5 months ago

First of all, thanks for the nodes! What's the point of stacking LORAs if you can't use NONE in none of them? When setted to NONE, the node should output the unmodified inputs MODEL and CLIP. That would be an useful stacking. Thanks!

image

WAS-PlaiLabs commented 5 months ago

I don't have a Lora Stacker? That's a Lora Loader, just like the base ComfyUI lora loader, which also, has no None. The only difference is it outputs the name of the lora.

alonsojr1980 commented 5 months ago

Every node can be stacked, mate. The ComfyUI lora loader has no None, but it outputs the unchanged input when strength is zero. Your node should do the same when None is selected. I have made one of my own, so don't mind.

WAS-PlaiLabs commented 5 months ago

That's, just hooking nodes up. There are actual "Lora stacker" nodes. And this is Comfy's code. So set strength to 0? I'll see if he made changes.

alonsojr1980 commented 5 months ago

I fixed it myself, never mind.

image