search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Two "Load Image Batch" in the same workflow leads to a bug #395

Open Zeelyne opened 4 months ago

Zeelyne commented 4 months ago

Hello,

I want to combine two lists of masks from two separate folders. I tried to initiate a batch process with the following workflow:

image

Interestingly, when I choose "random" or "single_image" in the "Load Image Batch," it works. However, if I choose "incremental_image," both "Load Image Batch" nodes keep outputing only the first image of their respective folders. No error message but the output is not what I suppose to get.

Then, I bypassed one of the "Load Image Batch" nodes to see the output when using "incremental_image." This time, it worked correctly! image

It seems that there is a bug when using two "Load Image Batch" nodes in the same workflow. Can anyone tell me how to solve this problem?

Many thanks.

Zeelyne commented 4 months ago

Oh I just found that, by using two different values in the "lable" for these two "load image batch", this problem can be solved. However I am not very clear with the behind reason for that. Waiting for a more detailed explanation for this issue.

WAS-PlaiLabs commented 4 months ago

Oh I just found that, by using two different values in the "lable" for these two "load image batch", this problem can be solved. However I am not very clear with the behind reason for that. Waiting for a more detailed explanation for this issue.

The nodes are from before node classes were persistent, so it's data is being stored in a dictionary, and the key to that nodes data is the label.

These days, it could be updated to store it's data on the class itself, since they are persistent now, and just use the node's ID and have no need for a label.

Zeelyne commented 4 months ago

OK thank you! Hope to see the update