search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Update to pack has broken all Image Save nodes in all existing workflows #401

Open alkemann opened 4 months ago

alkemann commented 4 months ago

The problem is that there was added arguments, changed orders. The added DPI field takes the quality value that is stored in workflows and the new quality field gets NaN (probably a boolean). See attached screenshot on the left is how all my existing workflows are now showing up as. Please revert this change and add a new Image Save with DPI or something like that. image

WAS-PlaiLabs commented 4 months ago

This is just the name of the game for ComfyUI when nodes update. It stores values as an array, no key relating to actual fields. Recreate your nodes.

alkemann commented 4 months ago

I understand that is how the framework work, which is why I propose you make a new node when you want to make breaking changes.

WAS-PlaiLabs commented 4 months ago

Thanks for the suggestion. I don't have the time to be making whole new nodes for minor adjustments, and the pack is plenty large enough as it is.

If you want to PR a revert and maybe a stand-alone JPEG / PNG node (I think that's all that support it in PIL) I'll definitely consider it, but I don't have the time ATM for at least until after the 7th of June.