search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.23k stars 178 forks source link

Installation issues with ComfyUI-Manager #405

Closed thjan closed 6 months ago

thjan commented 6 months ago

Hi, I am using the comfy-cli to install my workflow dependencies with comfy node install-deps --workflow which worked perfectly until this morning. It seems that during one of the recent db updates, a node named ComfyUI_MaraScott_Nodes appeared which declares many (many) nodes. A bunch of these nodes are shipped as included third parties from other node packages.

What I mean by that is that in ComfyUI_MaraScott_Nodes/py/vendor the following packages are included:

ComfyUI_Impact_Pack ComfyUI_LayerStyle ComfyUI_tinyterraNodes mikey_nodes was_node_suite_comfyui

These packages are also available to be downloaded by the manager itself and present in the extension-node-map.json file. This creates a situation where some node names are duplicated between several packages: Text Concatenate is now defined by was_node_suite AND ComfyUI_MaraScott_Nodes

Is there a way to either specify a preference, blacklist, whitelist or any kind of mechanism that could allow going for the package I want and not the first in the list providing the custom node I need ?

I know this question would belong more in the comfyui manager or comfy-cli repo, but I was thinking this might have happened to people here already and they have a solution :)

Thank you !

WASasquatch commented 6 months ago

This is definitely a new situation I for one wasn't expecting. Regular name confliction, sure, but an entire pack re-shipper in another.

Thanks for brining this to my attention. I will think on this but at face value it seems best if people didn't do this. Cause short from me implementing changes and breaking workflows (since basically beginning of ComfyUI), it seems on them to manage this better.

thjan commented 6 months ago

It seem to have been a problem in the manager scripts and it has been fixed, shipped nodes are no longer exposed in the nodemap file -> https://github.com/ltdrdata/ComfyUI-Manager/issues/718#issuecomment-2135088774

I am still a bit worried about potential collisions if nodes start being repackaged in others but it seem ok for now :)

I've been using your nodes for quite some time and they are great. Thank your for your hard work, you're amazing !

WASasquatch commented 6 months ago

Yeah that has me worried too. Thank you for looking into this, and thanks again for the kind words. Much appreciated 🙏