WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.15k stars 170 forks source link

Is there to make it compatible with py 3.9 ? #428

Closed davedaverave closed 2 months ago

davedaverave commented 3 months ago

My enviroment can't be upgraded, if there's no other way what commit should i go back to? THanks for the patience :)

WASasquatch commented 3 months ago

What are the problems you are having?

davedaverave commented 3 months ago

this the message in console "Cannot import /notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui module for custom nodes: cannot import name 'BlipProcessor' from 'transformers' (/usr/local/lib/python3.9/dist-packages/transformers/init.py)"

WASasquatch commented 3 months ago

Might want to take that error to Transformers since they say they support 3.8+ but is erroring for you.

On Wed, Jul 3, 2024, 2:10 PM davedaverave @.***> wrote:

this the message in console "Cannot import /notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui module for custom nodes: cannot import name 'BlipProcessor' from 'transformers' (/usr/local/lib/python3.9/dist-packages/transformers/init.py)"

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/428#issuecomment-2207302754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZP7QOQRTMBOQDJ2VK3ZKRSC3AVCNFSM6AAAAABKJ5U5AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBXGMYDENZVGQ . You are receiving this because you commented.Message ID: @.***>

davedaverave commented 3 months ago

I'm pasting you the full message " Traceback (most recent call last): File "/notebooks/ComfyUI/nodes.py", line 1906, in load_custom_node module_spec.loader.exec_module(module) File "", line 850, in exec_module File "", line 228, in _call_with_frames_removed File "/notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui/init.py", line 1, in from .WAS_Node_Suite import NODE_CLASS_MAPPINGS File "/notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui/WAS_Node_Suite.py", line 2398, in from transformers import BlipProcessor, BlipForConditionalGeneration, BlipForQuestionAnswering ImportError: cannot import name 'BlipProcessor' from 'transformers' (/usr/local/lib/python3.9/dist-packages/transformers/init.py)

Cannot import /notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui module for custom nodes: cannot import name 'BlipProcessor' from 'transformers' (/usr/local/lib/python3.9/dist-packages/transformers/init.py) "

If that's it, i will write them as well about this issue... thanks

WASasquatch commented 3 months ago

Yeah the error is from Transformers, not WAS-NS. Transformers claims to be compatible with Python 3.6+,but you are clearly having issues. You need to report with them

On Thu, Jul 4, 2024, 6:11 AM davedaverave @.***> wrote:

Reopened #428 https://github.com/WASasquatch/was-node-suite-comfyui/issues/428.

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/428#event-13394831166, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZPJ5WYPXOYHJJUAC5TZKVCZPAVCNFSM6AAAAABKJ5U5AKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGM4TIOBTGEYTMNQ . You are receiving this because you commented.Message ID: <WASasquatch/was-node-suite-comfyui/issue/428/issue_event/13394831166@ github.com>

davedaverave commented 2 months ago

I've did .. i as well noticed a different error today... Hope you don't mind

File "/notebooks/ComfyUI/nodes.py", line 1906, in load_custom_node module_spec.loader.exec_module(module) File "", line 850, in exec_module File "", line 228, in _call_with_frames_removed File "/notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui/init.py", line 1, in from .WAS_Node_Suite import NODE_CLASS_MAPPINGS File "/notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui/WAS_Node_Suite.py", line 37, in from numba import jit ModuleNotFoundError: No module named 'numba'

Cannot import /notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui module for custom nodes: No module named 'numba'

Does it make sense?

WASasquatch commented 2 months ago

Numba should install. It was also compatible with 3.6: https://numba.pydata.org/numba-doc/latest/user/installing.html

On Fri, Jul 5, 2024, 4:25 AM davedaverave @.***> wrote:

I've did .. i as well noticed a different error today... Hope you don't mind

File "/notebooks/ComfyUI/nodes.py", line 1906, in load_custom_node module_spec.loader.exec_module(module) File "", line 850, in exec_module File "", line 228, in _call_with_frames_removed File "/notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui/init.py", line 1, in from .WAS_Node_Suite import NODE_CLASS_MAPPINGS File "/notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui/WAS_Node_Suite.py", line 37, in from numba import jit ModuleNotFoundError: No module named 'numba'

Cannot import /notebooks/ComfyUI/custom_nodes/was-node-suite-comfyui module for custom nodes: No module named 'numba'

Does it make sense?

— Reply to this email directly, view it on GitHub https://github.com/WASasquatch/was-node-suite-comfyui/issues/428#issuecomment-2210703184, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZEZLSJU2EGGHY3O4X243ZKZ7A3AVCNFSM6AAAAABKJ5U5AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJQG4YDGMJYGQ . You are receiving this because you commented.Message ID: @.***>

davedaverave commented 2 months ago

I've found out that the Last Ben repository for running ComfyUI on Paperspace is not being supported anymore, as the author is having issure with the platform and that's escalated making him remove the repo...

That coud be related to the issues i was having, i will close this issue for now, until i've fount out... thanks a lot

dreamlogic-X commented 2 months ago

@davedaverave Hey I noticed I'm having the same issue, I'm also on the Last Ben's Paperspace notebook. It's running Python 3.11.7. Wondering if you found a resolution?