WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.23k stars 178 forks source link

Fixing broken node WAS_Find ("Text Find") #455

Closed aurel-g closed 3 months ago

aurel-g commented 3 months ago

This node was broken : in the GUI there were 7 individual outputs named "f", "o", "u", "n", "d", "A", "N" instead of one named "found" of type boolean.

GUI before fix:

before

GUI after fix:

after

JSON node definition from /object_info endpoint before fix:

{
  "input": {
    "required": {
      "text": [
        "STRING",
        {
          "forceInput": true
        }
      ],
      "substring": [
        "STRING",
        {
          "default": "",
          "multiline": false
        }
      ],
      "pattern": [
        "STRING",
        {
          "default": "",
          "multiline": false
        }
      ]
    }
  },
  "output": "BOOLEAN",
  "output_is_list": [
    false,
    false,
    false,
    false,
    false,
    false,
    false
  ],
  "output_name": "found",
  "name": "Text Find",
  "display_name": "Text Find",
  "description": "",
  "python_module": "custom_nodes.was-node-suite-comfyui",
  "category": "WAS Suite/Text/Search",
  "output_node": false
}

JSON node definition from /object_info endpoint after fix:

{
  "input": {
    "required": {
      "text": [
        "STRING",
        {
          "forceInput": true
        }
      ],
      "substring": [
        "STRING",
        {
          "default": "",
          "multiline": false
        }
      ],
      "pattern": [
        "STRING",
        {
          "default": "",
          "multiline": false
        }
      ]
    }
  },
  "output": [
    "BOOLEAN"
  ],
  "output_is_list": [
    false
  ],
  "output_name": [
    "found"
  ],
  "name": "Text Find",
  "display_name": "Text Find",
  "description": "",
  "python_module": "custom_nodes.was-node-suite-comfyui",
  "category": "WAS Suite/Text/Search",
  "output_node": false
}
WAS-PlaiLabs commented 3 months ago

https://github.com/WASasquatch/was-node-suite-comfyui/pull/440 Previous PR also targeted this, so I merged it.