search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.19k stars 178 forks source link

Update WAS_Node_Suite.py #76

Closed shadownetdev1 closed 1 year ago

shadownetdev1 commented 1 year ago

changed TEXT_TYPE from "TEXT" to "STRING" for cross compatibility with other custom nodes

shadownetdev1 commented 1 year ago

This seemed to work but then stopped working. It seems that ComfyUI has a bug where you can have "STRING" as an output type but if it is an input type the node will not load into the workspace and there is no error message. Looking for a potential fix because using "STRING" is ideal in my opinion.

shadownetdev1 commented 1 year ago

The magic is to set "text": {"STRING", {forceInput: True}}. This means that making this will require much more work that I have put in at this point. I will be closing this pull request and will open a new one when ready.

WASasquatch commented 1 year ago

Yeah, last I tested it was broken too giving errors for custom nodes when importing workflows.

Serious bug that suddenly int/float/string etc are reserved for front end cause of primitives requiring special treatment.