WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.19k stars 178 forks source link

Image Paste Crop by location - feathering buggy #80

Closed Ferniclestix closed 1 year ago

Ferniclestix commented 1 year ago

The crop blending does not seem to want to hit zero at the edges, it will leave fine lines unless it is set extremely low to the point of uselessness. The crop blend also does so on all sides even if it is at the border edge of the image it is being pasted into which causes issues if you want to paste an image in a corner or on an edge.

Im not actually a coder or anything so its hard for me to explain what is happening, so here's an example image and nodegraph Im messing with, I could easily just be implementing it wrong maybe, but it feels like it shouldn't be doing what it does.

splitupscaletest.txt ComfyUI_00937_ - you can see the fine lines near the monsters head where I have overlaid an image to show how its creating a fine line where one should probably not exist around it.

WASasquatch commented 1 year ago

No I see what you mean, and I thought I fixed this. Not the border edges by the boundary edges in general. The way it works is the square shrinks as you apply more blur so that the actual blurring shouldn't hit the edge of the crop (so parts of the blue get cut off). But apparently that isn't working as I thought it was.

WASasquatch commented 1 year ago

Alright I rebuilt the function for side detection.

image image

Ferniclestix commented 1 year ago

Captur99999e hmmm, more strangeness, it doesnt like crops that are against eachother, and seems to be a little inconsistant with it. not sure how i'd handle it, a checkbox merge edges maybe? also 2 output images but only one functions on those nodes. Captur999e Capkij9ture

edge to image edge works a treat where it does work tho tho :D seems to have trouble with some corners.

Edit: made a tester plus some sample images to mess with :D, looks like all crop types suffer from similar bugs cropping tester.txt chk blk wht

WASasquatch commented 1 year ago

I'm not good with math. I may just revert to old method. Too much of a hassle.

Update: Try latest patch.