search

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.22k stars 177 forks source link

numa error when install #82

Closed kenyonxu closed 1 year ago

kenyonxu commented 1 year ago

image

WASasquatch commented 1 year ago

It's a typo in requirements. That should be "numba" with a B.

DivinoAG commented 1 year ago

I tried fixing that typo on the requirements file, but it doesn't seem like it's triggering Comfy to download the correct libraries. Is there anything else that needs to be done here?

WASasquatch commented 1 year ago

I tried fixing that typo on the requirements file, but it doesn't seem like it's triggering Comfy to download the correct libraries. Is there anything else that needs to be done here?

I think numba comes with Python 3.10. The official numba website says to just try it, and doesn't specify to install first (however here is it's install page: https://numba.readthedocs.io/en/stable/user/installing.html). But it does have a pip package, so in case someone removed it, it would need to be reinstalled. I didn't need to install it to use it myself with ComfyUI portable, it was already there.

It's only used for the perlin code, so that it can calculate it's noise muuuch faster then numpy/cv2 would in python itself

DivinoAG commented 1 year ago

Well, I never did anything related to it (I'm not a developer, so I never touch anything related to Python, nor was I aware of numba's existence until today), and your addon is no longer working since this update. Below is the error message from Comfy even after I made the change to the requirements file to numba instead of numa.

image

WASasquatch commented 1 year ago

Did you not re-run the requirements after it was patched? You should always be sure to run the requirements with new changes, as their may be new requirements, like numba.

Run from within WAS Node Suite directory root C:\path\to\ComfyUI\python_embeded\python.exe -s -m pip install -r requirements.txt

Or numba directly C:\path\to\ComfyUI\python_embeded\python.exe -s -m pip install numba

If you ran the commands wrong, and not with ComfyUI's Python, you may have installed a python system install, in which case you'll need to uninstall that so it stops conflicting.

DivinoAG commented 1 year ago

I assumed that happened when Comfy is starting since I have never done that before. I guess that's my mistake.