WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes
MIT License
1.19k stars 178 forks source link

width and height around the wrong way #86

Closed Ferniclestix closed 1 year ago

Ferniclestix commented 1 year ago

Perlin noise node and maybe more have width and height around the wrong way.

additionally, generate background gradient suffers a similar problem with horizontal and verticall mislabeled

WASasquatch commented 1 year ago

Seem to be working fine. You sure about that? Cause I'm not sure what you're talking about.

image image image

Ferniclestix commented 1 year ago

mysterious o.0 ill look into it lol because its definitely buggy on my end

yeh, still doing it. - gradient fixed with update Capture

Ferniclestix commented 1 year ago

ok, specifically happens with the nodes in that order, perlin noise going first into an imageblend node causes it. if perlin is on the bottom it behaves as directed.... odd.

WASasquatch commented 1 year ago

Still working as expected...

Screenshot_17 image image image

The blend nodes don't resize images, so if you aren't sizing them right, strange things will happen:

image

I've been using these same nodes for making procedural textures and input noise and haven't seen the issue described. Additionally, are you restarting ComfyUI and getting old cache images showing instead of the actual fresh image?

Ferniclestix commented 1 year ago

found it, bugs fixed, issue with python install somehow was doing it >.> numba was bugging but not actually erroring until I did a restart then it wouldn't load was anymore. I have no idea how that happened and my coder friend is mystified lol i had him have a look to see what was wrong and he's like, nope its fine. your computers magical. sadface soo we spent like a couple of hours hunting down the problem lol - your fine, all me >.> - corrupt python install or something

WASasquatch commented 1 year ago

Ohh, ok! Yeah I kept looking at the code completely mistified too. I was just like "I can't see anything! There are FOUR LIGHTS!" (star trek reference)

Ferniclestix commented 1 year ago

now, captain picard, i have a question for you... how many lights do you see? def one of the good eps.

nahh, should be good now, friend sorted it all, lucky i have a housemate who is my pet coder lol, or id still be insisting there are four lights!