Types: Added type hints and cleaned up some type issues.

WASasquatch / was-node-suite-comfyui

An extensive node suite for ComfyUI with over 210 new nodes

MIT License

1.22k stars 177 forks source link

Types: Added type hints and cleaned up some type issues. #9

Closed DrJKL closed 1 year ago

DrJKL commented 1 year ago

Accidentally had the formatter running, so this is much noisier than I would like. There are still a lot of Unknown types and it looks like pylance and opencv2 don't agree on some method signatures.

WASasquatch commented 1 year ago

Awesome work.

Me and opencv don't get alone so I hear ya there. You can see that in my avoidance as much as possible. If PIL has a wrapper for it, I am gonna use it. Lol

WASasquatch commented 1 year ago

Alright. So stuck on mobile right now for awhile (out and about) and the web edit is apparently messed up. Can't compare to spot anything that needs fixing to merge. May be a bit.

DrJKL commented 1 year ago

Okay, merged the most recent changes at main

WASasquatch commented 1 year ago

Gotcha.