On branch edburns-msft-ibm-7891-support-pre-pushed-acr-image WIP: support deployment of pre-pushed image to pre-existing Azure Container Registry, such as ejb02ibm781.azurecr.io/jakartaee-microprofile-example:v1 - Githubissues

WASdev / azure.liberty.aks

Apache License 2.0

2 stars 8 forks source link

On branch edburns-msft-ibm-7891-support-pre-pushed-acr-image WIP: support deployment of pre-pushed image to pre-existing Azure Container Registry, such as ejb02ibm781.azurecr.io/jakartaee-microprofile-example:v1 #117

Closed edburns closed 2 months ago

edburns commented 2 months ago

On branch edburns-msft-ibm-7891-support-pre-pushed-acr-image Skip inspecting the manifest if the image comes from Azure Container Registry. modified: pom.xml

Increment version.

modified: src/main/scripts/preflight.sh

Assume that if SOURCE_IMAGE_PATH comes from azurecr.io it is assumed to meet the requirements of being a valid container image for running Liberty on Kubernetes.

modified: src/main/bicep/mainTemplate.bicep

Fix issue where fully qualified azurecr.io tags were incorrectly prepended with docker.io.

majguo commented 2 months ago

Testing

The latest code changes are published to my testing offer, and I verified the following 6 test cases with its preview link:	ACR	app docker image path	expected deployment status
ejb02ibm781.azurecr.io	ejb02ibm781.azurecr.io/jakartaee-microprofile-example:v1	Succeeded
new	icr.io/appcafe/open-liberty/samples/getting-started	Succeeded
acr9dadaa.azurecr.io	icr.io/appcafe/open-liberty/samples/getting-started	Succeeded
new	ejb02ibm781.azurecr.io/jakartaee-microprofile-example:v1	Failed
acr9dadaa.azurecr.io	ejb02ibm781.azurecr.io/jakartaee-microprofile-example:v1	Failed
ejb02ibm781.azurecr.io	ejb02ibm781.azurecr.io/jakartaee-microprofile-example:v2	Failed