WASdev / azure.liberty.aks

Apache License 2.0
2 stars 8 forks source link

Add support for WebSphere Liberty Operator #65

Closed git4rk closed 1 year ago

git4rk commented 1 year ago

Notes:

majguo commented 1 year ago

Based on the procedure of deployment, WLO/OLO should be installed before deploying application image. As a result, I think we should add new tab Configure operator before the existing tab Configure application.

edburns commented 1 year ago

Based on the procedure of deployment, WLO/OLO should be installed before deploying application image. As a result, I think we should add new tab Configure operator before the existing tab Configure application.

I agree with @majguo here. @git4rk can you please weigh in?

gcharters commented 1 year ago

I like the design and agree with Configure operator coming before Configure application. I think we will need some informational text to explain what "IBM Supported" means. Must have licenses to cover deployment, blah, blah.

I think we should also install the License Service operator for supported deployments and provide instructions for where to access the information from it.

gcharters commented 1 year ago

I’ve thought about this a bit more and think the above approach is not quite right.

The license information being provided is specific to the container being deployed. A single operator instance can deploy multiple containers, each under different licenses (e.g. Liberty Core, Liberty Base).

I think we should update the Configure application tab to be: Configure Operator and application (should Operator be uppercase because it’s a specific thing? :/). Feel free to choose a better name. Maybe just Operator and application or Configure deployment.

We should add a param at the top: IBM Supported or Trial: yes/no (default: no)

The rest of the proposal remains the same.

Help information for the new param should say: “Choose yes if your deployments are to be supported under existing WebSphere entitlements (this includes supported deployments of Open Liberty). Choose yes if you are deploying WebSphere Liberty under the Trial license terms. Choose no if you are deploying Open Liberty unsupported”

majguo commented 1 year ago

Thanks @git4rk, @edburns & @gcharters for your comments.

I created the mockup, and you can preview the UI changes using the Create UI Definition Sandbox:

Also attached the screenshots for quick overview:

Please review and respond if you have any comments.

gcharters commented 1 year ago

@majguo this looks good to me.

majguo commented 1 year ago

Per my testing and this doc, IBM WebSphere Server Family Edition should be changed to IBM WebSphere Application Server Family Edition. The screenshot above is also updated.

git4rk commented 1 year ago

@gcharters @edburns @majguo Based on our recent experience/discussion (outside of this offering), I think we need to revisit the design:

So, I think, the UI should be like:

image image image image