Open scottkurz opened 5 years ago
hey @scottkurz - thanks for getting this started. I think you're right that we can improve this. We have had a few issues on this board related to passwords, so I am very supportive of a new system for this.
In most cases the tWAS server will be connected to some LDAP, which would make the password file irrelevant. So would be good to have an easy toggle between the different scenarios (i.e. generate a password for me vs let me mount my password vs just use the configured LDAP, etc).
This issue with mounting new password after configure.sh run should be resolved with the latest images. But overall I agree we need to maybe re-think the password mechanism and addition of LDAP configuration scripts
fyi @gmarcy
This is an issue that's real easy to workaround, once you understand, but still maybe worth considering if we could do something better in this step.
If I build an image with the
configure.sh
script it'll generate a/tmp/PASSWORD
and a/work/passwordupdated
marker file.The problem is that the
start_server.sh
we use in our command won't update with the new password supplied from a mount, since the marker file is there.There are a few ways I can think of to work around this. E.g. using a CMD like:
bash -c 'rm /work/passwordupdated; /work/start_server.sh'
.Of course, users can do that themselves on the run command once they understand the logic of all of this, so let me pause and see if anyone else thinks this is worth addressing.