search

WASdev / lib.rtcomm.clientjs

Rtcomm client Javascript libraries (includes WebRTC support)
Apache License 2.0
15 stars 8 forks source link

Ringing Continues Until All ICE Candidates Are Collected #78

Closed jfmartinez closed 8 years ago

jfmartinez commented 8 years ago

While disabling trickleICE for SIP Trunking the ringing continued on endlessly due to the collection of ICE Candidates and up until the session:started even, this change will stop the ringing when the ICE Candidates start being collected (almost immediately after accepting the incoming session request).

This change also creates a new event for the WebRTCConnection - 'connecting' and for the RtcommEndpoint - 'session:connecting'.

jfmartinez commented 8 years ago

@swgraham I did a hotfix for this issue on the branch issue-78, but due to the changes you've made with the sub protocols I'm not sure where the correct way to stop the ringing on accept dialog would be. Any clue?

swgraham commented 8 years ago

@jfmartinez I just merged your work into develop w/ the subprotocol changes. Can you pull it into your environment and do some testing w/ your apps before I push to master? Thanks