search

WASdev / standards.jsr352.jbatch

Home of 'jbatch', a compatible implementation of the Jakarta Batch specification (and the former Reference Implementation for the JSR 352, Batch Applications for the Java Platform specification).
Other
21 stars 18 forks source link

Added transition elements to schema and bindings of Split to get it to b... #1

Closed smillidge closed 9 years ago

smillidge commented 9 years ago

I had to make the following changes to get this to build with maven. Obviously this changes the xsd so may not be what you want.

BrentDouglas commented 9 years ago

I believe your issue is actually caused by a problem with the force="no" attribute on line 108 of the macro appendExtraCode in the JAXB build.xml (https://github.com/WASdev/standards.jsr352.jbatch/blob/master/com.ibm.jbatch.container/adjustJAXB/build.xml#L108). If you remove the force="no", your build should complete with no modifications to the xsd required, thought if you are using jdk8 you may also have to set the system property javax.xml.accessExternalSchema to file. See https://github.com/BrentDouglas/standards.jsr352.jbatch/commit/37fd7db0f6385ae8fb37cdb1c092c1d92c5b7201.

To better understand what's causing the issue on you can delete the line <delete file="${generate.dir}/@{class}.java.tmp"/> (https://github.com/WASdev/standards.jsr352.jbatch/blob/master/com.ibm.jbatch.container/adjustJAXB/build.xml#L114), run a build and, when it fails, look at the java files and the tmp files. You should end up seeing something like this: http://pastie.org/9645464 As you can see the .java files have a later modification date that the .tmp files which will cause the ant to skip concatenating the files due to the force="no" attribute (see https://ant.apache.org/manual/Tasks/concat.html).

smillidge commented 9 years ago

Thanks, that works, is this change to build.xml in one of your pull requests?

BrentDouglas commented 9 years ago

No worriee, it is part of this one https://github.com/WASdev/standards.jsr352.jbatch/pull/3.

BrentDouglas commented 9 years ago

Bah, no worries*. I'm not good on phone keyboards.

scottkurz commented 9 years ago

Thanks Brent for clarifying this issue. I'm looking at your commit now. (And since we can't change the specification XSD I'll close this one).

Also note this link describing the CLA we'd need to view and accept contributions on this project.