search

WASdev / standards.jsr352.jbatch

Home of 'jbatch', a compatible implementation of the Jakarta Batch specification (and the former Reference Implementation for the JSR 352, Batch Applications for the Java Platform specification).
Other
21 stars 18 forks source link

[#6105] JDK8 javadoc issues #13

Closed BrentDouglas closed 9 years ago

BrentDouglas commented 9 years ago

Fixes a bunch of javadoc the JDK8 linter doesn't like. All changes are stylistic only and shouldn't affect the content.

The linter is ignored on both the module with XJC generated classes as I don't think it is possible to make xjc use > rather than > when generating javadoc, and the TCK module as there are a bunch of invalid tags that look like they are used by some other tooling not included in this repo.

scottkurz commented 9 years ago

Brent, I pulled the first commit, but not the second. The -Xdoclint:none option seems to cause Java 7 builds to fail, and I don't have any better ideas at the moment.

BrentDouglas commented 9 years ago

Sorry about that, I should have tested it with both JDK's. I have updated it to be compatible with both.

scottkurz commented 9 years ago

Brent, I appreciate the work you did collapsing the EE vs SE build profiles into one here.

I moved away from that, though, in my last commit 329a56d, which I just pushed. This allows JVM System properties to be used instead.

Using the properties files was unwieldy for anyone consuming this. In spite of the effort put into the build profiles, the "SE mode" was unavailable to anyone directly consuming the jbatch artifacts from Maven (without copying this file into place).

Anyway, I appreciate the Java 8 enablement. I think I got the gist of your changes in this merge, but please let me know if you think I missed anything.

Thanks

BrentDouglas commented 9 years ago

Sounds like a good change. When writing the weld test I recall it was a pain to work out how to change the config.