search

WASdev / standards.jsr352.jbatch

Home of 'jbatch', a compatible implementation of the Jakarta Batch specification (and the former Reference Implementation for the JSR 352, Batch Applications for the Java Platform specification).
Other
21 stars 18 forks source link

Add Qualifier to BatchPropertyProducer #19

Closed smillidge closed 9 years ago

smillidge commented 9 years ago

With the latest Weld I am getting errors for injecting @BatchProperty in a class.

WELD-001475: The following beans match by type, but none have matching qualifiers:

I believe this is because the method below in com.ibm.jbatch.container/src/main/java/com/ibm/jbatch/container/cdi/BatchProducerBean.java needs the @BatchProperty qualifier adding as currently it just says it produces a String and this can clash with other classes that produce a String

@Produces @Dependent @BatchProperty public String produceProperty(InjectionPoint injectionPoint)

scottkurz commented 9 years ago

I thought we had that @BatchProperty there all along.... maybe we lost it or never implemented the idea fully.

Thanks for pointing that out.

BrentDouglas commented 9 years ago

I'm pretty sure I fixed this in PR #4 (weld reinitialization).

Brent

smillidge commented 9 years ago

Looking at the old code here http://repo1.maven.org/maven2/com/ibm/jbatch/com.ibm.jbatch-runtime/1.0/ this appears to have been lost in the migration to the new structure.

scottkurz commented 9 years ago

Thanks for noting that. I went back and it seems to be an isolated mix-up, not a bigger issue merging across the project restructuring (and one which the lack of tests here didn't catch).

Sorry about that.

Anyway I added back just the annotation in be9ba4ccb7da710105cb9485729825b739667e4c

I still intend to review Brent's change separately.. I know it's been out there awhile.

(Also not sure what the tmp snapshot update is but if you're asking me to look please let me know).

smillidge commented 9 years ago

I think the tmp snapshot update is overzealous cross linking by GitHub. We just pushed a temp fix into a Payara patches maven repo as we are debugging it for a customer so gave him a build with a patched JBatch to test.

No need to take a look.