WASdev / standards.jsr352.jbatch

Home of 'jbatch', a compatible implementation of the Jakarta Batch specification (and the former Reference Implementation for the JSR 352, Batch Applications for the Java Platform specification).
Other
21 stars 18 forks source link

Re-add sigtest and downloadable zip to build; Run TCK in build #7

Closed BrentDouglas closed 9 years ago

BrentDouglas commented 9 years ago

Firstly, this is based on https://github.com/WASdev/standards.jsr352.jbatch/pull/3 so please look at that before this one.

This might cause some merge conflicts with some of the other PR's, of so let me know when you merge them and I will rebase it.

scottkurz commented 9 years ago

@BrentDouglas - This is the next thing I'm looking at. Looks like you've done quite a bit here which I do greatly appreciate. Going to take me a couple sessions to digest it all, but just wanted to send a quick acknowledgement (2 months later!).

scottkurz commented 9 years ago

Brent, this is a huge help. Thank you! (When I get around to writing a TCK contributor guide I have to remember to give you a major credit for this work.)

I think you addressed all the key areas currently visible. There is also the build logic we used internally to convert the TCK tests to CTS tests, which I plan to share shortly but just haven't yet.

As the next step, I'm going to go ahead and merge this in, but not release to Maven just yet.

Then I'd like to give a bit more thought to how I will name the versions.... and do a bit more testing, after we which we can actually release this out there in Maven for others to consume.

Thanks again!

scottkurz commented 9 years ago

Appreciate if you can take a quick look at the result. I spent too much time messing around with the merge commits and messages and ended up pushing the result without checking again (for now). Thanks

BrentDouglas commented 9 years ago

A few minor things had changed since I wrote it. They are fixed in #28