WASdev / websphere-liberty-operator

Deploy and manage containerized Liberty applications on Kubernetes. Documentation: https://ibm.biz/wlo-docs
Apache License 2.0
9 stars 4 forks source link

Handle Semeru Compiler status for upgrade scenario #326

Open smcclem opened 1 year ago

smcclem commented 1 year ago

https://github.com/WASdev/websphere-liberty-operator/pull/317#issuecomment-1311065590

@smcclem Noticed that the application status is checked within ManageError (here), which would override the status message added for Semeru. It'll be replaced with the status of application resources. I think this would be a problem in upgrade scenarios. It can be recreated by deploying semeru and app, wait for the overall status to be ready and then update the CR to specify an invalid applicationImage. The status would probably still report as ready.

One simple solution is to skip the application status check within ManageError if the condition type is StatusConditionTypeResourcesReady.

leochr commented 1 year ago

@smcclem There is still a problem with this scenario when status is reported. The status of ResourcesReady condition is good. But the Reconciled and Ready conditions still report the previous status and should be set to False and messages should be updated accordingly when this occurs.

Screen Shot 2022-11-21 at 2 53 03 PM