search

WBCE / WBCE_CMS

Core package of WBCE CMS. This package includes the core and the default addons. Visit https://wbce.org (DE) or https://wbce-cms.org (EN) to learn more or to join the WBCE CMS community.
https://wbce-cms.org
GNU General Public License v2.0
32 stars 22 forks source link

Last update of a page is not reliable #430

Closed instantflorian closed 5 years ago

instantflorian commented 5 years ago

The "last update" information is incorrect if there are no wysiwyg sections (for example only miniform or sth. else) on the page. The last update information is not updated even if settings of the page are changed. 2019-07-03_130340

ghost commented 5 years ago

I can confirm this bug. If this happens it will display the creation time instead of last modified (checked with a newly created site)

webbird commented 5 years ago

Modules supporting the last modified date set $update_when_modified to true. If there is no such module on a page, the last modified date will never be updated.

instantflorian commented 5 years ago

This is quite strange, because miniform has a save button, /miniform/save.php is executed and in the save.php is also the line $update_when_modified = true; - so I don't see why the last update information is not changed.

When changing the page settings, the update date of the page is never changed, I'm not sure if this is intended and useful. I tried adding the $update_when_modified = true; to /admin/settings2.php, but that does not help.

ghost commented 5 years ago

i think that the function in modules/admin.php#L191 is broken

see forum

instantflorian commented 5 years ago

Error does not appear with other modules (wysiwyg, code2, menulink, topics, mpform, sitemap) - but the error appears also with minigallery (minigal has a a save button on its settings panel)

ghost commented 5 years ago

Could it be that there are some incompatibilities between WBCE and WB (that is, our modules are working properly, cross-CMS modules like minigal not)?

instantflorian commented 5 years ago

I don't think thats the reason, since other cross CMS modules like code2, mpform or bootstrap multiple columns do not show that error.

instantflorian commented 5 years ago

https://github.com/WBCE/WBCE_CMS/commit/8c08e97c509636e4c69553a6a238baf9ce06567a