search

WBCE / WBCE_CMS

Core package of WBCE CMS. This package includes the core and the default addons. Visit https://wbce.org (DE) or https://wbce-cms.org (EN) to learn more or to join the WBCE CMS community.
https://wbce-cms.org
GNU General Public License v2.0
32 stars 22 forks source link

Better protection against wrongly executed install.php #461

Closed instantflorian closed 4 years ago

instantflorian commented 4 years ago

Yesterday a customer of mine deleted nearly 1/3 of his website due to running Add-Ons > Modules > install.php. All information stored in the specific module (here: itemz) was lost. Yes,, there is a warning, and yes, one can ask why this customer has access rights for the add-on page, but anyway. We should rework that part to avoid such cases in the future, for example by a second confirmation (are you sure), mandatory entering the user's password for confirmation and/or making a backup of existing tables before they would be erased by install/update.php. 2019-11-14_102537

dev4me commented 4 years ago

I would suggest to show "install.php" just for the modules that are not yet installed. Uploading through FTP and run install.php should still be possible. Running install.php on a previous installed module is always a bad idea.

Running update.php could also be more intelligent :) Only make update available when the version is different from the info.php version.

instantflorian commented 4 years ago

solved in development branch