WBHarry / introduce-me

MIT License
3 stars 3 forks source link

V8 Compatibility #19

Closed WallaceMcGregor closed 2 years ago

WallaceMcGregor commented 2 years ago

Although in the module.json it says that the minimum version is 8, it does not work. I am in version 0.8.9 and I have not been able to install it. Maybe it is because before versions were 0.8.X instead of 8.

WBHarry commented 2 years ago

Heya. Good catch. That was indeed the issue 😁 I released a new minor version, 0.9.4.3 that set the minimumCoreVersion correctly. I tested it on 0.8.9 and was able to download and use it.

WallaceMcGregor commented 2 years ago

Thanks! I can now install it.👌

The only thing that does not work is the template menu. Pressing the button does not open it.

WBHarry commented 2 years ago

Interesting, I did set up and use a template when I tried it on 0.8.9. Could you open up the console in foundry (F12), and check in the 'Console' tab if there's any informative error popping up when you try to open the template menu? 🤔

WallaceMcGregor commented 2 years ago

I don't know if it is because I am using the OSE system.

chrome_FZ9O4TnsGk

WBHarry commented 2 years ago

Hm, I understand the error, but not how it could happen. I tried on 0.8.9, OSE system with templates just now 😅

If you'd be willing to give me a little more debugging info, it'd be neat if you could try checking something in the console. If you type and enter: Handlebars.helpers, you'll get a list you can look in. I'm interested in what's in that list.

The error is essentially saying that a helper method supplied by Foundry itself doesn't exist, which is strange.

WallaceMcGregor commented 2 years ago

I don't know if this is it.

chrome_dgb0LetXiK

WBHarry commented 2 years ago

Yes, that is what I was looking for.

I released minor version 0.9.4.4. It includes a fix that should hopefully resolve any oddities on version 0.8.9, aswell as the updated spanish translation you provided 🥳

WallaceMcGregor commented 2 years ago

The template menu is now working!

Thanks.