search

WBHarry / introduce-me

MIT License
3 stars 3 forks source link

Introduce with Permission doesn't work #23

Closed Txus5012 closed 2 years ago

Txus5012 commented 2 years ago

Hi. It seems that the option to give limited permission to players after introduction doesn't work anymore. The permissions don't change. I tried it in different systems.

WBHarry commented 2 years ago

Hm, I can't replicate the issue on Foundry V9. I did correct an error that made the permission change only apply to the actual token on the screen though - IE at the moment if you drag out a new token from the actor, that one won't have the limited permission set. I'll push this out together with V10 things I'm looking at currently.

Is the above the issue you were having? Looking at the permissions for the actor will currently show it not changing :grin:

Txus5012 commented 2 years ago

Maybe I didn't understand what this feature is for.

I thought that this option changed the permission of the actor, so it showed to the players in the actor's tab because "he/she already introduced himself/herself". Permission This is what I wrote it didn't update (tried with the last update too).

WBHarry commented 2 years ago

That's very curious. It does do exactly that on the latest version (0.9.4.6) image

Txus5012 commented 2 years ago

I've been testing this more. It seems to work only if "Set Display Name" is also activated (I had it desactivated because I always set the Display Name to "Hovered by Anyone").

I made a new D&D5e world without other modules, to check that it wasn't a system/module compatibility issue. Used the latest version (0.9.4.6).

WBHarry commented 2 years ago

image Well, what do you know. The data update of permissions was actually erroneously stuck behind the 'Set Display Name' flag. Nice catch! I pushed out 0.9.4.7 right now with a fix. Edit: Make that 0.9.4.8. This isn't my day 🦺

Txus5012 commented 2 years ago

That seems to work. Thanks for the quick fix!