fix(checkout): Duplicate HTML id attribute on time select output

[bmenant]

All Submissions:

• [x] Have you followed the plugin Contributing guideline?
• [x] Does your code follow the WordPress' coding standards?
• [x] Have you checked to ensure there aren't other open Pull Requests) for the same update/change?

Changes proposed in this Pull Request:

Appends _wrapper to the id attribute of the <div> element of the public view/form.

Fixes a regression introduced in 1.4.0 where both the <select> and the <div> elements took the same value local_pickup_time_select returned from get_order_post_key() .

Prior to 1.4.0, the <div> element was identified with this hard-coded value: local-pickup-time-select using dashes instead of underscores (https://github.com/WC-Local-Pickup/woocommerce-local-pickup-time/blob/1.3.13/public/class-local-pickup-time.php#L692).

This duplicate html id has caused various issues with custom client-side logic around the local pickup field and comes with accessibility issues (since the for attribute of <label> element does not link to the field element anymore on some/all (?) browsers).

Other information:

• [x] Have you added an explanation of what your changes do and why you'd like us to include them?
• [ ] Have you written new tests for your changes, as applicable? No public unit tests yet.
• [ ] Have you successfully run tests with your changes locally? No public unit tests yet.

Changelog entry

• Changed <div> wrapper id attribute value to local_pickup_time_select_wrapper.
• Fixed duplicate html id with <select> element.

[bmenant]

Here you can see the duplicate html id (v1.4.2) this PR addresses:

[timnolte]

@bmenant thanks for flagging this. I'm going to accept this as-is but I think I'm going to address the fact that I incorrectly changed out id/class values with underscores instead of dashes.