search

WCRP-CMIP / CMIP6_CVs

Controlled Vocabularies (CVs) for use in CMIP6
Creative Commons Attribution 4.0 International
155 stars 79 forks source link

source_id registration of GFDL-AM4, GFDL-ESM4, GFDL-CM4 and GFDL-ESM2M #318

Closed aradhakrishnanGFDL closed 5 years ago

aradhakrishnanGFDL commented 7 years ago 
"GFDL-AM4":{
"activity_participation":[
"CMIP"
            ],
"cohort":[
"Registered"
            ],
"institution_id":[
"NOAA-GFDL"
            ],
"label":"GFDL-AM4",
"label_extended":"GFDL-AM4",
"model_component":{
"aerosol":{
"description":"interactive",
"nominal_resolution":"100km"
                },
"atmos":{
"description":"GFDL-AM4.0 (Cubed-sphere (c96) - 1 degree nominal horizontal resolution; 360x180 longitude/latitude; 33 levels; model top: 1 hPa)",
"nominal_resolution":"100 km"
                },
"atmosChem":{
"description":"fast chemistry, aerosol only",
"nominal_resolution":"100km"
                },
"land":{
"description":"GFDL-LM4.0",
"nominal_resolution":"100km"
                },
"landIce":{
"description":"GFDL-LM4.0",
"nominal_resolution":"100 km"
                },
"ocean":{
"description":"none",
"nominal_resolution":"none"
                },
"ocnBgchem":{
"description":"none",
"nominal_resolution":"none"
                },
"seaIce":{
"description":"none",
"nominal_resolution":"none"
                }
            },
"release_year":"2017",
"source_id":"GFDL-AM4"
        },
"GFDL-CM4":{
"activity_participation":[
"CMIP",
"OMIP"
            ],
"cohort":[
"Registered"
            ],
"institution_id":[
"NOAA-GFDL"
            ],
"label":"GFDL-CM4",
"label_extended":"GFDL-CM4",
"model_component":{
"aerosol":{
"description":"interactive",
"nominal_resolution":"100km"
                },
"atmos":{
"description":"GFDL-AM4.1 (Cubed-sphere (c96) - 1 degree nominal horizontal resolution; 360x180 longitude/latitude; 33 levels; model top: 1 hPa)",
"nominal_resolution":"100 km"
                },
"atmosChem":{
"description":"unnamed (fast chemistry, aerosol only)",
"nominal_resolution":"100km"
                },
"land":{
"description":"GFDL-LM4.0",
"nominal_resolution":"100km"
                },
"landIce":{
"description":"GFDL-LM4.0",
"nominal_resolution":"100 km"
                },
"ocean":{
"description":"GFDL-MOM6 (tripolar - nominal 0.25 deg latitude/longitude; 1440x720 longitude/latitude; 75 levels; top grid cell 0-2 m)",
"nominal_resolution":"25 km"
                },
"ocnBgchem":{
"description":"none",
"nominal_resolution":"25km"
                },
"seaIce":{
"description":"SIS2",
"nominal_resolution":"25km"
                }
            },
"release_year":"2017",
"source_id":"GFDL-CM4"
        },
"GFDL-ESM4":{
"activity_participation":[
"AerChemMIP",
"C4MIP",
"CFMIP",
"CMIP",
"DAMIP",
"DynVarMIP",
"GMMIP",
"LUMIP",
"OMIP",
"RFMIP",
"ScenarioMIP"
            ],
"cohort":[
"Registered"
            ],
"institution_id":[
"NOAA-GFDL"
            ],
"label":"GFDL-ESM4",
"label_extended":"GFDL-ESM4",
"model_component":{
"aerosol":{
"description":"interactive",
"nominal_resolution":"100 km"
                },
"atmos":{
"description":"GFDL-AM4.1 (Cubed-sphere (c96) - 1 degree nominal horizontal resolution; 360x180 longitude/latitude; 49 levels, model top: 1 Pa)",
"nominal_resolution":"100 km"
                },
"atmosChem":{
"description":"GFDL-ATMCHEM4.1 (full atmospheric chemistry)",
"nominal_resolution":"100 km"
                },
"land":{
"description":"GFDL-LM4.1",
"nominal_resolution":"100 km"
                },
"landIce":{
"description":"GFDL-LM4.1",
"nominal_resolution":"100 km"
                },
"ocean":{
"description":"GFDL-MOM6 (tripolar - nominal 0.5 deg; 720x360 longitude/latitude; 75 levels; top grid cell 0-2 m)",
"nominal_resolution":"50 km"
                },
"ocnBgchem":{
"description":"COBALT 2.0",
"nominal_resolution":"50 km"
                },
"seaIce":{
"description":"SIS2",
"nominal_resolution":"50 km"
                }
            },
"release_year":"2017",
"source_id":"GFDL-ESM4"
        },
durack1 commented 7 years ago

@aradhakrishnanGFDL thanks for this, peek at CMIP6_source_id.html and let me know if any further tweaks are required

aradhakrishnanGFDL commented 6 years ago

Some changes are needed as we review the CV once again :( Sorry about that. But, the next few comments will provide the edits.

aradhakrishnanGFDL commented 6 years ago

"GFDL-ESM4":{ "activity_participation":[ "CMIP", "AerChemMIP", "C4MIP", "CMIP", "DAMIP", "DynVarMIP", "LUMIP", "OMIP", "ScenarioMIP" ], "cohort":[ "Registered" ], "institution_id":[ "NOAA-GFDL" ], "label":"GFDL-ESM4", "label_extended":"GFDL-ESM4", "model_component":{ "aerosol":{ "description":"interactive", "nominal_resolution":"100 km" }, "atmos":{ "description":"GFDL-AM4.1 (Cubed-sphere (c96) - 1 degree nominal horizontal resolution; 360x180 longitude/latitude; 49 levels, model top: 1 Pa)", "nominal_resolution":"100 km" }, "atmosChem":{ "description":"GFDL-ATMCHEM4.1 (full atmospheric chemistry)", "nominal_resolution":"100 km" }, "land":{ "description":"GFDL-LM4.1", "nominal_resolution":"100 km" }, "landIce":{ "description":"GFDL-LM4.1", "nominal_resolution":"100 km" }, "ocean":{ "description":"GFDL-MOM6 (tripolar - nominal 0.5 deg; 720x360 longitude/latitude; 75 levels; top grid cell 0-2 m)", "nominal_resolution":"50 km" }, "ocnBgchem":{ "description":"COBALT 2.0", "nominal_resolution":"50 km" }, "seaIce":{ "description":"SIS2", "nominal_resolution":"50 km" } }, "release_year":"2017", "source_id":"GFDL-ESM4" },

aradhakrishnanGFDL commented 6 years ago

CM4 had CMIP removed while viewing the official CV. So, I am adding that here again plus few more edits:

"GFDL-CM4":{ "activity_participation":[ "CMIP", "OMIP", "CFMIP", " RFMIP", "GMMIP" ], "cohort":[ "Registered" ], "institution_id":[ "NOAA-GFDL" ], "label":"GFDL-CM4", "label_extended":"GFDL-CM4", "model_component":{ "aerosol":{ "description":"interactive", "nominal_resolution":"100km" }, "atmos":{ "description":"GFDL-AM4.1 (Cubed-sphere (c96) - 1 degree nominal horizontal resolution; 360x180 longitude/latitude; 33 levels; model top: 1 hPa)", "nominal_resolution":"100 km" }, "atmosChem":{ "description":"unnamed (fast chemistry, aerosol only)", "nominal_resolution":"100km" }, "land":{ "description":"GFDL-LM4.0", "nominal_resolution":"100km" }, "landIce":{ "description":"GFDL-LM4.0", "nominal_resolution":"100 km" }, "ocean":{ "description":"GFDL-MOM6 (tripolar - nominal 0.25 deg latitude/longitude; 1440x720 longitude/latitude; 75 levels; top grid cell 0-2 m)", "nominal_resolution":"25 km" }, "ocnBgchem":{ "description":"GFDL BLING v2", "nominal_resolution":"25km" }, "seaIce":{ "description":"SIS2", "nominal_resolution":"25km" } }, "release_year":"2017", "source_id":"GFDL-CM4" },

aradhakrishnanGFDL commented 6 years ago

"GFDL-ESM​2M​":{ "activity_participation":[ "CMIP", ​"FAFMIP" ], "cohort":[ "Registered" ], "institution_id":[ "NOAA-GFDL" ], "label":"GFDL-ESM​2M​", "label_extended":"GFDL-ESM​2M​", "model_component":{ "aerosol":{ "description":"interactive", "nominal_resolution":"​​ 100km" }, "atmos":{ "description":"GFDL-AM​2 (Cubed-sphere (C48L24 144x90 (2.5 deg lon x 2 deg lat), 24 vertical)", "nominal_resolution":"​200km" }, "atmosChem":{ "description":"GFDL-ATMCHEM​3 (full atmospheric chemistry)", "nominal_resolution":"200km" }, "land":{ "description":"GFDL-LM​3", "nominal_resolution":"200km" }, "landIce":{ "description":"GFDL-LM4​3", "nominal_resolution":"200km" }, "ocean":{ "description":"GFDL-MOM6 360x200 (nominal 1 deg ocean), 50 vertical", "nominal_resolution":"100km" }, "seaIce":{ "description":"SIS", "nominal_resolution":"100km" } }, "release_year":"201​2", "source_id":"GFDL-ESM​2M​" },

durack1 commented 6 years ago

@aradhakrishnanGFDL thanks, in the GFDL-ESM2M registration there are a few tweaks required, and I have taken a pass at these below, and have either an XXX or ## note where more info is required

"atmos":{
"description":"GFDL-AM​2 (Cubed-sphere, C48L24, 2.5 deg lon x 2 deg lat; 144x90 longitude/latitude; 24 levels; model top XXX hpa)",
"nominal_resolution":"​200 km"
...
"ocean":{
"description":"GFDL-MOM6 (nominal 1 deg; 360x200 longitude/latitude; 50 levels; top grid cell 0-10 m)",
"nominal_resolution":"100 km"
},
"seaIce":{
"description":"SIS", ## IS THERE A VERSION TO BE RECORDED HERE??
"nominal_resolution":"100 km"
durack1 commented 6 years ago

@aradhakrishnanGFDL from the global attributes of the GFDL-ESM2M CMIP5 contributed data, I have pulled this:

:source = "GFDL-ESM2M 2010 ocean: MOM4 (MOM4p1_x1_Z50_cCM2M,Tripolar360x200L50); atmosphere: AM2 (AM2p14,M45L24); sea ice: SIS (SISp2,Tripolar360x200L50); land: LM3 (LM3p7_cESM,M45)" ;

And have updated the entries noted above with this additional detail appropriately.

From memory this model also included ocnBgchem, which is not included in your description above - will this be turned on for CMIP6?

All the changes noted above (and via email) are included in the new pull request which can be viewed directly here

durack1 commented 6 years ago

@aradhakrishnanGFDL @ceblanton these changes are now in place. Take a peek at CMIP6_source_id.html or for more granular info WCRP-CMIP/CMIP6_CVs/CMIP6_source_id.json and we can make the final tweaks by reopening this issue and indicating what remains to be changed

aradhakrishnanGFDL commented 6 years ago

@durack1 The top level in ESM2M is at approximately 3 hPa.

"description":"GFDL-AM​2 (Cubed-sphere, C48L24, 2.5 deg lon x 2 deg lat; 144x90 longitude/latitude; 24 levels; model top 3 hpa)",

aradhakrishnanGFDL commented 6 years ago

Not sure if the ordering of components needs to be as-is in the global attributes WIP CV reference. But, we are updating our source in netCDF to this:

GFDL-CM4 (2017): atmos: GFDL-AM4.1 (Cubed-sphere (c96) - 1 degree nominal horizontal resolution; 360 x 180 longitude/latitude; 33 levels; top level 1 hPa); ocean: GFDL-MOM6 (tripolar - nominal 0.25 deg; 1440 x 720 longitude/latitude; 75 levels; top grid cell 0-2 m); seaIce: SIS2 ; land: GFDL-LM4.0; aerosol: interactive; atmosChem: unnamed (fast chemistry, aerosol only); ocnBgchem: GFDL BLING v2; landIce: GFDL-LM4.0

durack1 commented 6 years ago

Further changes requested, reopening

durack1 commented 6 years ago

@aradhakrishnanGFDL take a peek at CMIP6_source_id.html and let me know if any other tweaks are required

durack1 commented 6 years ago

@aradhakrishnanGFDL we noted a formatting inconsistency with the aerosol, atmos, atmosChem, land and landIce nominal_resolution values for GFDL-ESM2M, and have now corrected this. Please check your complete model registration details in CMIP6_source_id.html and get back to me with any further tweaks required.

For reference, this issue was caught and resolved in WCRP-CMIP/CMIP6_CVs#466

aradhakrishnanGFDL commented 6 years ago

Requesting updates for GFDL-AM4, CM4 and ESM4 to release_year (2018).

    "GFDL-AM4":{
        "release_year":"2018",
    },
    "GFDL-CM4":{
        "release_year":"2018",
    },
    "GFDL-ESM4":{
        "release_year":"2018",
    },
durack1 commented 6 years ago

@aradhakrishnanGFDL is the only change to update the release_year? It's not clear if anything else above has changed for any of the models

aradhakrishnanGFDL commented 6 years ago

@durack1 Yes, change to release_year only. Others remain unchanged.

durack1 commented 6 years ago

@aradhakrishnanGFDL that change is now implemented, please take a peek at CMIP6_source_id.html and let me know if any further tweaks are required

aradhakrishnanGFDL commented 6 years ago

Hi @durack1 Requesting to add DynVarMIP as part of activity_participation for GFDL-CM4. This is the only change for GFDL-CM4 at this time.

(I have been requested to make two minor edits to GFDL-ESM2M. I will add another comment with those changes after verifications with other GFDL scientists. Sorry for the inconvenience)

    "GFDL-CM4":{
        "activity_participation":[
            "CFMIP",
            "CMIP",
            "GMMIP",
            "OMIP",
            "RFMIP",
            "DynVarMIP"
        ],
        "cohort":[
            "Registered"
        ],
        "institution_id":[
            "NOAA-GFDL"
        ],
        "label":"GFDL-CM4",
        "label_extended":"GFDL-CM4",
        "model_component":{
            "aerosol":{
                "description":"interactive",
                "native_nominal_resolution":"100 km"
            },
            "atmos":{
                "description":"GFDL-AM4.1 (Cubed-sphere (c96) - 1 degree nominal horizontal resolution; 360 x 180 longitude/latitude; 33 levels; top level 1 hPa)",
                "native_nominal_resolution":"100 km"
            },
            "atmosChem":{
                "description":"unnamed (fast chemistry, aerosol only)",
                "native_nominal_resolution":"100 km"
            },
            "land":{
                "description":"GFDL-LM4.0",
                "native_nominal_resolution":"100 km"
            },
            "landIce":{
                "description":"GFDL-LM4.0",
                "native_nominal_resolution":"100 km"
            },
            "ocean":{
                "description":"GFDL-MOM6 (tripolar - nominal 0.25 deg; 1440 x 720 longitude/latitude; 75 levels; top grid cell 0-2 m)",
                "native_nominal_resolution":"25 km"
            },
            "ocnBgchem":{
                "description":"GFDL BLING v2",
                "native_nominal_resolution":"25 km"
            },
            "seaIce":{
                "description":"SIS2",
                "native_nominal_resolution":"25 km"
            }
        },
        "release_year":"2018",
        "source_id":"GFDL-CM4"
    },
durack1 commented 6 years ago 
    "GFDL-CM4":{
        "activity_participation":[
            "CFMIP",
            "CMIP",
+           "DynVarMIP",
            "GMMIP",
            "OMIP",
            "RFMIP"
        ],
durack1 commented 6 years ago

@aradhakrishnanGFDL please drop the additional edit in this issue, and I'll process both GFDL-CM4 and GFDL-ESM2M changes together

durack1 commented 6 years ago

@aradhakrishnanGFDL any chance those GFDL-ESM2M tweaks are ready for inclusion? If you add them to this issue I'll process both GFDL changes at once

aradhakrishnanGFDL commented 6 years ago

@durack1 Sorry, not yet. I will get back to you shortly.

durack1 commented 6 years ago

@aradhakrishnanGFDL no problem, I just wanted to make sure I wasn't holding anything up!

aradhakrishnanGFDL commented 5 years ago

CV changes. We have updated the descriptions of most components, a couple activity removals and additions. Except for GFDL-AM4, all the other GFDL models in the CV have some level of changes.

Here is my fork for reference.

https://rawgit.com/aradhakrishnanGFDL/CMIP6_CVs/aradhakrishnanGFDL-patch-1/src/CMIP6_source_id.html

https://github.com/aradhakrishnanGFDL/CMIP6_CVs/edit/aradhakrishnanGFDL-patch-1/CMIP6_source_id.json

"GFDL-CM4":{ "activity_participation":[ "CFMIP", "CMIP", "GMMIP", "OMIP", "RFMIP", "DynVarMIP", "ScenarioMIP" ], "cohort":[ "Registered" ], "institution_id":[ "NOAA-GFDL" ], "label":"GFDL-CM4", "label_extended":"GFDL-CM4", "model_component":{ "aerosol":{ "description":"interactive", "native_nominal_resolution":"100 km" }, "atmos":{ "description":"GFDL-AM4.0.1 (Cubed-sphere (c96) - 1 degree nominal horizontal resolution; 360 x 180 longitude/latitude; 33 levels; top level 1 hPa)", "native_nominal_resolution":"100 km" }, "atmosChem":{ "description":"fast chemistry, aerosol only", "native_nominal_resolution":"100 km" }, "land":{ "description":" GFDL-LM4.0.1 (1 degree nominal horizontal resolution; 360 x 180 longitude/latitude; 20 levels; bot level 10m) ; land-Veg:unnamed (dynamic vegetation, dynamic land use) ; land-Hydro:unnamed (soil water and ice, multi-layer snow, rivers and lakes)", "native_nominal_resolution":"100 km" }, "landIce":{ "description":"GFDL-LM4.0.1", "native_nominal_resolution":"100 km" }, "ocean":{ "description":"GFDL-OM4p25 (GFDL-MOM6, tripolar - nominal 0.25 deg; 1440 x 1080 longitude/latitude; 75 levels; top grid cell 0-2 m)", "native_nominal_resolution":"25 km" }, "ocnBgchem":{ "description":"GFDL-BLINGv2", "native_nominal_resolution":"25 km" }, "seaIce":{ "description":"GFDL-SIM4p25 (GFDL-SIS2.0, tripolar - nominal 0.25 deg; 1440 x 1080 longitude/latitude; 5 layers; 5 thickness categories)", "native_nominal_resolution":"25 km" } }, "release_year":"2018", "source_id":"GFDL-CM4" }, "GFDL-CM4C192":{ "activity_participation":[ "CMIP", "HighResMIP" ], "cohort":[ "Registered" ], "institution_id":[ "NOAA-GFDL" ], "label":"GFDL-CM4C192", "label_extended":"GFDL-CM4C192", "model_component":{ "aerosol":{ "description":"interactive", "native_nominal_resolution":"50 km" }, "atmos":{ "description":"GFDL-AM4C192 (Cubed-sphere (c192) - 0.5 degree nominal horizontal resolution; 720 x 360 longitude/latitude; 33 levels; top level 1 hPa)", "native_nominal_resolution":"50 km" }, "atmosChem":{ "description":"fast chemistry, aerosol only", "native_nominal_resolution":"50 km" }, "land":{ "description":"GFDL-LM4.0.1", "native_nominal_resolution":"50 km" }, "landIce":{ "description":"GFDL-LM4.0.1", "native_nominal_resolution":"50 km" }, "ocean":{ "description":"GFDL-OM4p25 (GFDL-MOM6, tripolar - nominal 0.25 deg; 1440 x 1080 longitude/latitude; 75 levels; top grid cell 0-2 m)", "native_nominal_resolution":"25 km" }, "ocnBgchem":{ "description":"none", "native_nominal_resolution":"none" }, "seaIce":{ "description":"GFDL-SIM4p25 (GFDL-SIS2.0, tripolar - nominal 0.25 deg; 1440 x 1080 longitude/latitude; 5 layers; 5 thickness categories)", "native_nominal_resolution":"25 km" } }, "release_year":"2018", "source_id":"GFDL-CM4C192" }, "GFDL-ESM2M":{ "activity_participation":[ "CMIP", "FAFMIP" ], "cohort":[ "Registered" ], "institution_id":[ "NOAA-GFDL" ], "label":"GFDL-ESM2M", "label_extended":"GFDL-ESM2M", "model_component":{ "aerosol":{ "description":"prescribed", "native_nominal_resolution":"250 km" }, "atmos":{ "description":"GFDL-AM2 (144 x 90 longitude/latitude; 24 levels; top level 1 hPa)", "native_nominal_resolution":"250 km" }, "atmosChem":{ "description":"prescribed", "native_nominal_resolution":"250 km" }, "land":{ "description":"GFDL-LM3.0", "native_nominal_resolution":"250 km" }, "landIce":{ "description":"GFDL-LM3.0", "native_nominal_resolution":"250 km" }, "ocean":{ "description":"GFDL-MOM4p1 (tripolar - nominal 1 deg; 360 x 200 longitude/latitude; 50 levels; top grid cell 0-10 m)", "native_nominal_resolution":"100 km" }, "ocnBgchem":{ "description":"GFDL-TOPAZ2", "native_nominal_resolution":"100km" }, "seaIce":{ "description":"GFDL-SIM2 (GFDL-SIS, tripolar - nominal 1 deg; 360 x 200 longitude/latitude; 3 layers; 5 thickness categories) ", "native_nominal_resolution":"100 km" } }, "release_year":"2012", "source_id":"GFDL-ESM2M" }, "GFDL-ESM4":{ "activity_participation":[ "AerChemMIP", "C4MIP", "CDRMIP", "CMIP", "DAMIP", "DynVarMIP", "LUMIP", "ScenarioMIP" ], "cohort":[ "Registered" ], "institution_id":[ "NOAA-GFDL" ], "label":"GFDL-ESM4", "label_extended":"GFDL-ESM4", "model_component":{ "aerosol":{ "description":"interactive", "native_nominal_resolution":"100 km" }, "atmos":{ "description":"GFDL-AM4.1 (Cubed-sphere (c96) - 1 degree nominal horizontal resolution; 360 x 180 longitude/latitude; 49 levels; top level 1 Pa)", "native_nominal_resolution":"100 km" }, "atmosChem":{ "description":"GFDL-ATMCHEM4.1 (full atmospheric chemistry)", "native_nominal_resolution":"100 km" }, "land":{ "description":"GFDL-LM4.1", "native_nominal_resolution":"100 km" }, "landIce":{ "description":"GFDL-LM4.1", "native_nominal_resolution":"100 km" }, "ocean":{ "description":"GFDL-MOM6 (tripolar - nominal 0.5 deg; 720 x 360 longitude/latitude; 75 levels; top grid cell 0-2 m)", "native_nominal_resolution":"50 km" }, "ocnBgchem":{ "description":"COBALT 2.0", "native_nominal_resolution":"50 km" }, "seaIce":{ "description":"SIS2", "native_nominal_resolution":"50 km" } }, "release_year":"2018", "source_id":"GFDL-ESM4" }, "GFDL-OM4p5B":{ "activity_participation":[ "CMIP", "OMIP" ], "cohort":[ "Registered" ], "institution_id":[ "NOAA-GFDL" ], "label":"GFDL-OM4p5B", "label_extended":"GFDL-OM4p5B", "model_component":{ "aerosol":{ "description":"none", "native_nominal_resolution":"none" }, "atmos":{ "description":"none", "native_nominal_resolution":"none" }, "atmosChem":{ "description":"none", "native_nominal_resolution":"none" }, "land":{ "description":"none", "native_nominal_resolution":"none" }, "landIce":{ "description":"none", "native_nominal_resolution":"none" }, "ocean":{ "description":"GFDL-OM4p5 (GFDL-MOM6, tripolar - nominal 0.5 deg; 720 x 576 longitude/latitude; 75 levels; top grid cell 0-2 m)", "native_nominal_resolution":"50 km" }, "ocnBgchem":{ "description":"GFDL-BLINGv2", "native_nominal_resolution":"50 km" }, "seaIce":{ "description":"GFDL-SIM4p5 (GFDL-SIS2.0, tripolar - nominal 0.5 deg; 720 x 576 longitude/latitude; 5 layers; 5 thickness categories)", "native_nominal_resolution":"50 km" } }, "release_year":"2018", "source_id":"GFDL-OM4p5B" },

aradhakrishnanGFDL commented 5 years ago

Here is some info on what changes were specifically made to this version of the CV pertaining to the GFDL models.

https://github.com/aradhakrishnanGFDL/CMIP6_CVs/commit/a55a2ce71164c8865853d56b43a53d798d25bbff

durack1 commented 5 years ago

@aradhakrishnanGFDL thanks for the update, are the changes in your forks master branch? It doesn't seem to show up from my comparison https://github.com/aradhakrishnanGFDL/CMIP6_CVs/compare/master...WCRP-CMIP:master

aradhakrishnanGFDL commented 5 years ago

@aradhakrishnanGFDL thanks for the update, are the changes in your forks master branch? It doesn't seem to show up from my comparison aradhakrishnanGFDL/CMIP6_CVs@master...WCRP-CMIP:master

not master, it's aradhakrishnanGFDL-patch-1

durack1 commented 5 years ago

@aradhakrishnanGFDL are you sure? The only changes that I see are those changes that I made in #601.

If you peruse https://github.com/aradhakrishnanGFDL/CMIP6_CVs/compare/aradhakrishnanGFDL-patch-1...WCRP-CMIP:master#diff-489143e4bba3ae87c83073d3c9b593c8 you should see what I mean - only BCC updates

durack1 commented 5 years ago

@aradhakrishnanGFDL great, got those changes which are now in #602. I'll await an update after @jgjgfdl has taken one last run through

aradhakrishnanGFDL commented 5 years ago

@aradhakrishnanGFDL great, got those changes which are now in #602. I'll await an update after @jgjgfdl has taken one last run through

Thank you. We are ready now! @jgjgfdl approved of the most recent version, we made a couple of changes which seem to be here https://github.com/WCRP-CMIP/CMIP6_CVs/pull/602/files commit: d6244eede25a112e1b94844d76e1760a4e18e61b

durack1 commented 5 years ago

@aradhakrishnanGFDL @jgjgfdl thanks for these tweaks, the changes should now in place. Please take a look at CMIP6_source_id.html and let me know if any further tweaks are required

jgjgfdl commented 5 years ago

Thanks Paul and Aparna.

Jasmin

On Fri, Sep 14, 2018 at 8:32 PM, Paul J. Durack notifications@github.com wrote:

@aradhakrishnanGFDL https://github.com/aradhakrishnanGFDL @jgjgfdl https://github.com/jgjgfdl thanks for these tweaks, the changes should now in place. Please take a look at CMIP6_source_id.html https://rawgit.com/WCRP-CMIP/CMIP6_CVs/master/src/CMIP6_source_id.html and let me know if any further tweaks are required

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WCRP-CMIP/CMIP6_CVs/issues/318#issuecomment-421516858, or mute the thread https://github.com/notifications/unsubscribe-auth/AKqYKIvZZrmgJdRmDmGPeomFAfbKRgFFks5ubEq2gaJpZM4NVqAF .

--

Jasmin John NOAA/GFDL 201 Forrestal Road Princeton, NJ 08540 609-452-5323

aradhakrishnanGFDL commented 5 years ago

@aradhakrishnanGFDL @jgjgfdl thanks for these tweaks, the changes should now in place. Please take a look at CMIP6_source_id.html and let me know if any further tweaks are required

Thank you, Paul! Looks good to me. As soon as https://github.com/PCMDI/cmip6-cmor-tables/blob/master/Tables/CMIP6_CV.json is updated, we can run more QC tests at GFDL for publishing . Thanks,

durack1 commented 5 years ago

@doutriaux1 @mauzey1 can you guys kick off an update to CMIP6_CV.json please?

Is the cronjob re-enabled?

aradhakrishnanGFDL commented 5 years ago

Hi @durack1 @doutriaux1 I see the most recent version of the CMIP6_CV.json in the CMOR repo now, which is great. Thank you.