WCRP-CORDEX / cordex-cmip6-cmor-tables

JSON Tables for CMOR3 to create CORDEX-CMIP6 datasets
https://wcrp-cordex.github.io/cordex-cmip6-cmor-tables
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Inconsistencies with CMIP6 #66

Open sol1105 opened 4 months ago

sol1105 commented 4 months ago

Hi @larsbuntemeyer

I just want to list a few inconsistencies I noticed between CORDEX-CMIP6 and CMIP6 CMOR tables. Some are or may be relevant for a successful application of the CMOR library:

Lastly, I noticed a small typo for od550aer: both the label and the out_name for od550aer are followed by a space:

"od550aer_": {
            [...]
            "out_name": "od550aer_",
            [...]
larsbuntemeyer commented 4 months ago

Thanks again @sol1105 very much appreciated! I'll split up your issues and work on that on our data request table. Just some few comments here:

I will add a test case with a vertical coordinate to the examples to make sure the CMOR tool works with it. The examples are created using the python API without the _cmip6_option (https://github.com/PCMDI/cmor/discussions/679#discussioncomment-3842956)) in the input dataset table.

larsbuntemeyer commented 4 months ago

@gnikulin should we include the original CMIP6 variable attribute "comment"? I would vote for that (although that might depend on the table_id if i remember correctly). Right now, we use the "Comments" column from the original CMIP6 data request.

larsbuntemeyer commented 4 months ago

By comparing cell_methods of current CORDEX data request with CMIP6 data request, i find the following inconsistencies (more details here: https://github.com/WCRP-CORDEX/data-request-table/issues/19)

out_name frequency cordex cmip6 cmip6_realm cmip6_table
evspsbl day area: time: mean area: mean where land time: mean land Eday
tsl mon area: time: mean area: mean where land time: mean land Lmon
tsl day area: time: mean area: mean where land time: mean land Eday
tsl 6hrPt area: mean time: point area: mean where land time: point land 6hrPlevPt
mrros mon area: time: mean area: mean where land time: mean land Lmon
mrros day area: time: mean area: mean where land time: mean land Eday
mrro mon area: time: mean area: mean where land time: mean land Lmon
mrro day area: time: mean area: mean where land time: mean land day
snm day area: time: mean area: mean where land time: mean landIce land Eday
mrfso mon area: time: mean area: mean where land time: mean land landIce Lmon
mrsfl mon area: time: mean area: mean where land time: mean land Emon
mrsfl day area: time: mean area: mean where land time: mean land Eday
mrso mon area: time: mean area: mean where land time: mean land Lmon
mrso day area: time: mean area: mean where land time: mean land day
mrsos mon area: time: mean area: mean where land time: mean land Lmon
mrsos day area: time: mean area: mean where land time: mean land day
mrsol mon area: time: mean area: mean where land time: mean land Emon
mrsol day area: time: mean area: mean where land time: mean land Eday
snw mon area: time: mean area: mean where land time: mean landIce land LImon
snw day area: time: mean area: mean where land time: mean landIce land day
snw 6hrPt area: mean time: point area: mean where land time: point landIce land 6hrPlevPt
snd mon area: time: mean area: mean where land time: mean landIce land LImon
snd day area: time: mean area: mean where land time: mean landIce land Eday
evspsblpot mon area: time: mean area: mean where land time: mean land Emon
evspsblpot day area: time: mean area: mean where land time: mean land Eday
mrsofc fx area: mean area: mean where land land fx

@gnikulin Should we stick with CMIP6 standard here? Note, that we don't have a modeling_realm in CORDEX for now...

gnikulin commented 3 months ago
* I really wasn't aware of the difference between "normal" vertical dimensions and singleton vertical dimensions, thanks for  that! @gnikulin Could you confirm that the soil variables in CORDEX-CMIP6 (`tsl`, `mrsfl` and `mrsol`) are supposed to be  "real" 3D variables (as it is mentioned in the comments [here](https://docs.google.com/spreadsheets/d/1qUauozwXkq7r1g-L4ALMIkCNINIhhCPx/#gid=1672965248)). They weren't part of the CMOR in tables in CMIP5 so i am not sure.

Yes, all 3 variables (tsl, mrsfl and mrsol) are "real" 3D (each soil layer).

gnikulin commented 3 months ago

@gnikulin should we include the original CMIP6 variable attribute "comment"? I would vote for that (although that might depend on the table_id if i remember correctly). Right now, we use the "Comments" column from the original CMIP6 data request.

Yes, I would also use "Comments" from CMIP6 when possible. We need to make minor adjustments because there are several inconsistencies in the CMIP6 comments attribute for some "similar" variables.

gnikulin commented 3 months ago

By comparing cell_methods of current CORDEX data request with CMIP6 data request, i find the following inconsistencies (more details here: WCRP-CORDEX/data-request-table#19) out_name frequency cordex cmip6 cmip6_realm cmip6_table evspsbl day area: time: mean area: mean where land time: mean land Eday tsl mon area: time: mean area: mean where land time: mean land Lmon tsl day area: time: mean area: mean where land time: mean land Eday tsl 6hrPt area: mean time: point area: mean where land time: point land 6hrPlevPt mrros mon area: time: mean area: mean where land time: mean land Lmon mrros day area: time: mean area: mean where land time: mean land Eday mrro mon area: time: mean area: mean where land time: mean land Lmon mrro day area: time: mean area: mean where land time: mean land day snm day area: time: mean area: mean where land time: mean landIce land Eday mrfso mon area: time: mean area: mean where land time: mean land landIce Lmon mrsfl mon area: time: mean area: mean where land time: mean land Emon mrsfl day area: time: mean area: mean where land time: mean land Eday mrso mon area: time: mean area: mean where land time: mean land Lmon mrso day area: time: mean area: mean where land time: mean land day mrsos mon area: time: mean area: mean where land time: mean land Lmon mrsos day area: time: mean area: mean where land time: mean land day mrsol mon area: time: mean area: mean where land time: mean land Emon mrsol day area: time: mean area: mean where land time: mean land Eday snw mon area: time: mean area: mean where land time: mean landIce land LImon snw day area: time: mean area: mean where land time: mean landIce land day snw 6hrPt area: mean time: point area: mean where land time: point landIce land 6hrPlevPt snd mon area: time: mean area: mean where land time: mean landIce land LImon snd day area: time: mean area: mean where land time: mean landIce land Eday evspsblpot mon area: time: mean area: mean where land time: mean land Emon evspsblpot day area: time: mean area: mean where land time: mean land Eday mrsofc fx area: mean area: mean where land land fx

@gnikulin Should we stick with CMIP6 standard here? Note, that we don't have a modeling_realm in CORDEX for now...

We need to check in detail. For all "soil" variables we indeed should use area: mean where land. However, for example evspsbl in the CMIP5 Amon table has "cell_methods": "area: time: mean" and is provided over both land and water.