vertices_latitude / vertices_longitude should not have attribute units

WCRP-CORDEX / cordex-cmip6-cmor-tables

JSON Tables for CMOR3 to create CORDEX-CMIP6 datasets

https://wcrp-cordex.github.io/cordex-cmip6-cmor-tables

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

vertices_latitude / vertices_longitude should not have attribute units #68

Open larsbuntemeyer opened 4 months ago

larsbuntemeyer commented 4 months ago

I am not sure why this is the case for the CMIP6_grids.json table but i think we should not have the units attribute in the boundary variables according to CF conventions:

https://github.com/WCRP-CORDEX/cordex-cmip6-cmor-tables/blob/80f7f510266884d372d68de6f4d63ffd68255f18/Tables/CORDEX-CMIP6_grids.json#L137-L156

larsbuntemeyer commented 4 months ago

see https://github.com/PCMDI/cmor/issues/729

gnikulin commented 3 months ago

I agree, the units attribute in the boundary variables is redundant information and the boundary variables shouldn't have any attributes, also consistent with the CF conventions.

larsbuntemeyer commented 3 months ago

OK, we can't really do anything about what cmor will write out here i guess. But the way it is now should be fine since these are recommendations. I'll leave the issue open anyway..