WDCommunity / wdpksrc

Cross compilation framework to create native packages for the Western Digital My Cloud
BSD 3-Clause "New" or "Revised" License
218 stars 54 forks source link

Updates to docker v19.03.3 #46

Closed JediNite closed 4 years ago

JediNite commented 4 years ago

This pull request contains updates for docker v19.03.3 and changed the location of the binaries to a new structure on my repository.

stefaang commented 4 years ago

LGTM. You should have edit rights now, so go ahead if you like.

stefaang commented 4 years ago

Maybe best to add a VERSION variable, which is then used in the TARBALL and REL_TAG variables. A future update is then a single line change in both files.

JediNite commented 4 years ago

I might see if I can rename the release names so they match more closely to the file names like you suggested.

Get Outlook for iOShttps://aka.ms/o0ukef


From: Stefaan Ghysels notifications@github.com Sent: Friday, October 11, 2019 7:46:14 PM To: WDCommunity/wdpksrc wdpksrc@noreply.github.com Cc: JediNite gersekow@hotmail.com; Author author@noreply.github.com Subject: Re: [WDCommunity/wdpksrc] Updates to docker v19.03.3 (#46)

Well maybe we could reuse that version number in the REL_TAG so that future edits are faster.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/WDCommunity/wdpksrc/pull/46?email_source=notifications&email_token=ADMYAD4HGTHDF7NFH74XITTQOBDONA5CNFSM4I7WZL62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA7PGSQ#issuecomment-540996426, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADMYAD643G6AK6VOGDWPAADQOBDONANCNFSM4I7WZL6Q.