search

WDscholia / scholia

Wikidata-based scholarly profiles
https://scholia.toolforge.org
Other
220 stars 78 forks source link

is the `# title` in the SPARQL queries meant to be used by the WDQS? #2304

Open egonw opened 1 year ago

egonw commented 1 year ago

Context

Multiple SPARQL queries have a title in a comment, e.g. https://github.com/WDscholia/scholia/blob/6d14811f1a52ec68c2b359f64807b306fd82d257/scholia/app/templates/venue_topics.sparql#L1

But many of # title: which is not recognized by the WDQS, while #title: is (see below screenshots).

The space is quite prevalent.

Question

Is the use of #title: in the queries meant to be used by the WDQS?

Screenshots

With space:

image

Without space:

image

Daniel-Mietchen commented 1 year ago

I think these should be without space, so as to give the blue ribbon atop of the results. Some of those with space might be older than that WDQS feature.

egonw commented 1 year ago

Okay, I will go ahead and make a patch then.

fnielsen commented 1 year ago

If I remember correctly, I added the "title" before Wikimedia (in Berlin?) started to use the keyword (without the space). I do not think we should use title because the iframes would then get a title banner which might not be visually nice on the scholia page. The "tool" keyword is added automagically. We could suggest that this becomes a Wikimedia keyword.

egonw commented 1 year ago

I do not think we should use title because the iframes would then get a title banner

Good point! I agree with that. We can remove that line when used in the iframe context, just like we add the #tool: line. Would that be an idea? Then when you open it with 'edit' in WDQS, then the title would be there (handy when people want to bookmark a particular query (for some Scholia/Wikidata item).