Removed visible links to Twitter - Githubissues

WDscholia / scholia

Wikidata-based scholarly profiles

https://scholia.toolforge.org

Other

215 stars 78 forks source link

Removed visible links to Twitter #2389

Closed egonw closed 5 months ago

egonw commented 7 months ago

Description

This patch removes user-visible links to X/Twitter.

Caveats

There may be more left. These can be filed a separate bug reports.

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
- [ ] I have made corresponding changes to the documentation
[ ] This change requires new dependencies (please list)

Workflows that depending on looking up Twitter accounts via the web interface will break (but that's intentional).

Testing

Without the patch, it currently looks like this:

After the patch, the link and logo for the X social account is gone.

Checklist

[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have not used code from external sources without attribution
[ ] I have considered accessibility in my implementation
[x] There are no remaining debug statements (print, console.log, ...)