Fix #2385 Use full title text for P1476 in OJS scraper - Githubissues

WDscholia / scholia

Wikidata-based scholarly profiles

https://scholia.toolforge.org

Other

219 stars 78 forks source link

Fix #2385 Use full title text for P1476 in OJS scraper #2402

Closed DaxServer closed 5 months ago

DaxServer commented 8 months ago

Fixes #2385

Description

Use complete text for P1476 in OJS Scraper as the field is capable to handling longer text.

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted Check any of the following which apply:

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
- [ ] I have made corresponding changes to the documentation
[ ] This change requires new dependencies (please list)

If you make changes to the Python code

[ ] My code passes the tox check, I can receive warnings about tests, documentation or both

Checklist

[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have not used code from external sources without attribution
[x] I have considered accessibility in my implementation
[x] There are no remaining debug statements (print, console.log, ...)

fnielsen commented 5 months ago

Due to the conflict, I instead made a new branch and PR #2474